Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: adp5589-keys - mark suspend and resume methods as
 __maybe_unused
Thread-Topic: [PATCH] Input: adp5589-keys - mark suspend and resume methods as
 __maybe_unused
Thread-Index: AQHWvkUCVa4Majlqrk+sPiO82zVfG6nPGcqg
Date:   Thu, 19 Nov 2020 08:08:50 +0000
Message-ID: <DM6PR03MB44112BAAFE36D19430FF0DC6F9E00@DM6PR03MB4411.namprd03.prod.outlook.com>
References: <20201119072418.GA114677@dtor-ws>
In-Reply-To: <20201119072418.GA114677@dtor-ws>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 58e30b20-2799-4316-5f97-08d88c62593a
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 08:08:50.3377
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jYQp92p3sSE7tvQwStk2gy3sfHcKSoNxJ8YORtKRFsSdo6BS4pXYcqHl7ZAKj/6S10OGPFECMkmlB4Ycqe0EzHFYL30HhPlwmwe10NRE6wA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4010
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-19_05:2020-11-17,2020-11-19 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0
 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011190059
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Thursday, November 19, 2020 9:24 AM
> To: linux-input@vger.kernel.org
> Cc: Ardelean, Alexandru <alexandru.Ardelean@analog.com>; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] Input: adp5589-keys - mark suspend and resume methods as
> __maybe_unused
>=20
> [External]
>=20
> This improves compile coverage of the code; unused code will be dropped b=
y the
> linker.
>=20

Acked-by: Alexandru Ardelean <Alexandru.ardelean@analog.com>

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/keyboard/adp5589-keys.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> index 31145a85c819..a9b69a268c09 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -1016,8 +1016,7 @@ static int adp5589_probe(struct i2c_client *client,
>  	return 0;
>  }
>=20
> -#ifdef CONFIG_PM_SLEEP
> -static int adp5589_suspend(struct device *dev)
> +static int __maybe_unused adp5589_suspend(struct device *dev)
>  {
>  	struct adp5589_kpad *kpad =3D dev_get_drvdata(dev);
>  	struct i2c_client *client =3D kpad->client; @@ -1033,7 +1032,7 @@ stati=
c
> int adp5589_suspend(struct device *dev)
>  	return 0;
>  }
>=20
> -static int adp5589_resume(struct device *dev)
> +static int __maybe_unused adp5589_resume(struct device *dev)
>  {
>  	struct adp5589_kpad *kpad =3D dev_get_drvdata(dev);
>  	struct i2c_client *client =3D kpad->client; @@ -1048,7 +1047,6 @@ stati=
c
> int adp5589_resume(struct device *dev)
>=20
>  	return 0;
>  }
> -#endif
>=20
>  static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend,
> adp5589_resume);
>=20
> --
> 2.29.2.299.gdc1121823c-goog
>=20
>=20
> --
> Dmitry