Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp284545pxb; Thu, 19 Nov 2020 00:42:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyUqYOZ5bIpgw9m/iIYFf5WYcNIPxxOb7iyfAcKAyMhYBD1IBekDn4OSU7p1fIASzwXfTz2 X-Received: by 2002:a17:906:e0d2:: with SMTP id gl18mr6109406ejb.412.1605775367929; Thu, 19 Nov 2020 00:42:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605775367; cv=none; d=google.com; s=arc-20160816; b=ITBvOT8inBBPMvdcv/YNgSnL8X5JNgihPyJyQg3VVeoi8bYUty9fr0yp6v/WA7MH4C ylgeyOkJbDncyshLoDdIBYEXdKQT2IhGgLIf2kIq+G9xDyJYsRVqnVJpr6uE1eMoUsw7 bBSB5eo/IYfBHAH0X22qt3MpMU+v7vOLH8EQ/bRMU6HEZ/c1iLI/sSDqBN24rlo0/K/J HnKzMJBM+EI7bh02ok3UwxmWSL3JYRvstA8qjGQDiRHya+2z+lkn/pGy2RfGPlXDCJwI x0xcJph3RboH97rI+Mp0Bhfl0BcjYn3lpTWXJekdX0VjG29GRialTZDmNvbapM6cr4jv bQIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qHzL1Qu+ntj/rvQyOCgLYXp8/Xk7sv86HqhHuURXsHI=; b=Yd56xHK4BGtsF13e6j6KcdoMhX032nASw6EZ1OVK+XYwQHEwmsEiJ4gsxqRXDfY8CW QVZKUv2xOGh89SG8Ys0Amodfapq7t+EnWIB/oayob/t9hg2fxOWeuKzAVr5dWAGGykCs 2RXhRCQmivdFYrfVH7BlYKLygBiBEZmcuMpvW//361ClLfBii0G5vyyyoN5VrCXbRLMD KZhnbjdDg8soW6c++v+mqVRp3islrccTVOhwWm0ihXwXTBKC/12wgvQTAZ12mM3bBzW4 3/C6pu1vyfTcb4oDRmgdwQSvK0sKHIzvJ3k/ZmeMsH+3Xnoe6mV39kLP30cZoRXKs/4J Yagw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si16837807ejf.335.2020.11.19.00.42.24; Thu, 19 Nov 2020 00:42:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726718AbgKSIif (ORCPT + 99 others); Thu, 19 Nov 2020 03:38:35 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:43342 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbgKSIif (ORCPT ); Thu, 19 Nov 2020 03:38:35 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 69BA71C0B87; Thu, 19 Nov 2020 09:38:31 +0100 (CET) Date: Thu, 19 Nov 2020 09:38:30 +0100 From: Pavel Machek To: Gene Chen Cc: Jacek Anaszewski , Rob Herring , Matthias Brugger , Dan Murphy , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions Message-ID: <20201119083830.GA31871@amd> References: <1605696462-391-1-git-send-email-gene.chen.richtek@gmail.com> <1605696462-391-3-git-send-email-gene.chen.richtek@gmail.com> <20201118213712.GA22371@amd> <20201119074416.GA27576@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > Moonlight has more current level(150mA) from general RGB LED (24mA). > > > It can be used as night-light and usually use color AMBER. > > > Camera flashes are usually use two flash LED. One is YELLOW, and one > > >is WHITE. > > > > From what I seen, night-lights are usually differetent "temperatures" > > of white. Cool white + warm white. > > > > I believe "warm white" would be easier to understand than > > "moonlight"... >=20 > ACK, I will change color "LED_COLOR_ID_WHITE" If you have two leds that differ only in one being "cool white" and one being "warm white", you may need to introduce defines for one of them. If not, keeping "LED_COLOR_ID_WHITE" is enough. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+2LwYACgkQMOfwapXb+vJyQACfYV2csyAq22QDr0kWaNLt5aNT ifoAn1b7uWaQPwk6nYu5GiDDzNFsPLup =d2jd -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--