Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in
 hard IRQ
To:     Tian Tao <tiantao6@hisilicon.com>, gregkh@linuxfoundation.org,
        afaerber@suse.de, manivannan.sadhasivam@linaro.org,
        linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <5d722862-f0a8-629e-b01e-5269350762e5@kernel.org>
Date:   Thu, 19 Nov 2020 10:03:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19. 11. 20, 10:01, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/serial/owl-uart.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c
> index c149f8c3..472fdaf 100644
> --- a/drivers/tty/serial/owl-uart.c
> +++ b/drivers/tty/serial/owl-uart.c
> @@ -251,10 +251,9 @@ static void owl_uart_receive_chars(struct uart_port *port)
>   static irqreturn_t owl_uart_irq(int irq, void *dev_id)
>   {
>   	struct uart_port *port = dev_id;
> -	unsigned long flags;
>   	u32 stat;
>   
> -	spin_lock_irqsave(&port->lock, flags);
> +	spin_lock(&port->lock);
>   
>   	stat = owl_uart_read(port, OWL_UART_STAT);
>   
> @@ -268,7 +267,7 @@ static irqreturn_t owl_uart_irq(int irq, void *dev_id)
>   	stat |= OWL_UART_STAT_RIP | OWL_UART_STAT_TIP;
>   	owl_uart_write(port, stat, OWL_UART_STAT);
>   
> -	spin_unlock_irqrestore(&port->lock, flags);
> +	spin_unlock(&port->lock);
>   
>   	return IRQ_HANDLED;
>   }
> 


-- 
js
suse labs