Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] MIPS: KASLR: Make relocation_address can be
 configured
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <1605752954-10368-1-git-send-email-hejinyang@loongson.cn>
 <1605752954-10368-3-git-send-email-hejinyang@loongson.cn>
 <7e6d428d-cf5d-e2ac-93fa-4996adc2defe@gmail.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Jinyang He <hejinyang@loongson.cn>
Message-ID: <4c56a146-211d-e2ba-4a77-96680a6d39bc@loongson.cn>
Date:   Thu, 19 Nov 2020 17:31:34 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <7e6d428d-cf5d-e2ac-93fa-4996adc2defe@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 11/19/2020 04:06 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 19.11.2020 5:29, Jinyang He wrote:
>
>> When CONFIG_RANDOMIZE_BASE is not set, determine_relocation_address()
>> always returns a constant. It is not friendly to users if the address
>> cannot be used. Make it can be configured at Kconfig.
>
>    Make it configurable?
Oh, yes. Sorry for the expression.
0xffffffff81000000 cannot be used on Loongson64 if CONFIG_RANDOMIZE_BASE 
is disabled.
It's lower than address of _end. It makes relocation_addr_valid() return 
0 always.

Thanks!
Jinyang

>> Signed-off-by: Jinyang He <hejinyang@loongson.cn>
> [...]
>
> MBR, Sergei