Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp324672pxb; Thu, 19 Nov 2020 02:05:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvwdxU9VVohkTUl0/WodpMPpVKdiROi4+9fkiCOK7W+bslfAWGUgzRKB6soK0CmaW6XaZy X-Received: by 2002:a17:906:840e:: with SMTP id n14mr27692163ejx.147.1605780300935; Thu, 19 Nov 2020 02:05:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605780300; cv=none; d=google.com; s=arc-20160816; b=ezXwQfQamxDG6DOdzslztdLSKHjIj0KGRzC3iwNWlo5gl5PByV7Y6PPbx1PbGRTaym ElBzXTIQBHXiGajtd/Gug7wAcVYaTz4XsaTgFJdTJOB/Ed5sPkzHdgNxiNUmxRYSskqf pOLzIy5A/fBkHZF4P8hcrr2mXckIy/3ANmfwg6O7ObNvdlwQ1NzptlUi4tdxkkWH8ZlZ VePrrhbPX/wiDDJIpCQgskhOps1ooIjEjiItrN3989CxOUq2oMcTM3DWV2+wsbUHnSiD XmmrkWbizlNMOatPuUA12Yd5yto0agymQaOxRQ6dLD4hIDue5BMRuFqJqj93NW+R52fj VIjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:ironport-sdr:ironport-sdr; bh=x8EnwH3MCVdGTzFTnGr9qL4YpEzorXYHKHZCM8Q7lfk=; b=YoarjGO8vX9MynbqMmHINidyQvoZ9ygppkfbUs3JPA0eymcJGcufRXu0rN5xM5GTY9 mP2q5wW7ATGJ6SQs7wG2KxJcLg2vc0woVRy8AXcp0/XbYF3uNDRL9AROaOsTo1fS2ybg BxSkhXwa4nwrslzwcrFe7BYLRXvRQTdvAPZJccM0ldZEWYjIrHJVs5xspypR/vD4CFtv hRfaqY+/9odAFFKYt5fnhtKOYdNQVBhhFiYUguG28GoTpCt+86rIe6TuBSk3qDMC79RT eEQAhOCweuXLaFUfYrVEb++B8m2KRpR27adinh1vuhOjk+P5D8GgD44iBQd5ex21fM4v O/oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs10si8845324ejc.227.2020.11.19.02.04.38; Thu, 19 Nov 2020 02:05:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbgKSKCu (ORCPT + 99 others); Thu, 19 Nov 2020 05:02:50 -0500 Received: from mga14.intel.com ([192.55.52.115]:10879 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbgKSKCt (ORCPT ); Thu, 19 Nov 2020 05:02:49 -0500 IronPort-SDR: AS2eBuEZPoiat6d5xTwA1LVmv5pw+pyipw+/L1Co9U4qLFzjpKdVXtbrhTuqmW+zRhj9Tlffy+ 7Lp5l4lBtxbw== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="170482245" X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="170482245" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 02:02:49 -0800 IronPort-SDR: jiEDvqRj5GkfRbyDAUn7Iw4gx/IYLh3nZ5pKIsyZlkRfiTmS4Ckc37v5LXtXHb1Ax4vtigu1gU 94jVRv9xMyJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="359909801" Received: from host.sh.intel.com ([10.239.154.115]) by fmsmga004.fm.intel.com with ESMTP; 19 Nov 2020 02:02:47 -0800 From: Ye Xiang To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ye Xiang Subject: [PATCH v2 3/4] iio: hid-sensor-trigger: Use iio->trig instead trig field internal structure Date: Thu, 19 Nov 2020 18:03:30 +0800 Message-Id: <20201119100331.2594-4-xiang.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201119100331.2594-1-xiang.ye@intel.com> References: <20201119100331.2594-1-xiang.ye@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use iio->trig instead of attrb->trig as parameter of iio_trigger_unregister and iio_trigger_free. This allows one HID sensor driver to create multiple iio devices. In this case common attributes are shared and there can be one instance for the structure containing common attributes for all iio devices. Signed-off-by: Ye Xiang --- drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c index 30340abcbc8d..bb5e7c8ff15b 100644 --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c @@ -236,8 +236,8 @@ void hid_sensor_remove_trigger(struct iio_dev *indio_dev, pm_runtime_put_noidle(&attrb->pdev->dev); cancel_work_sync(&attrb->work); - iio_trigger_unregister(attrb->trigger); - iio_trigger_free(attrb->trigger); + iio_trigger_unregister(indio_dev->trig); + iio_trigger_free(indio_dev->trig); iio_triggered_buffer_cleanup(indio_dev); } EXPORT_SYMBOL(hid_sensor_remove_trigger); -- 2.17.1