Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp419629pxb; Thu, 19 Nov 2020 04:53:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpeD3idZG2EmQJTv9UVDhjRkUUMSju8OYGKUw3ylFX521O7c3ghrb/vndIsA4jKJoxaa2h X-Received: by 2002:a05:6402:a57:: with SMTP id bt23mr29091975edb.62.1605790391258; Thu, 19 Nov 2020 04:53:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605790391; cv=none; d=google.com; s=arc-20160816; b=V83c3SkAwUJLpXRqstkBQszLP0i1k+GunRWE6EC+iBbq1z+L2SE6jfjyzVSkEZDVHC ZvbwBEJMICbueMkEeE0emnBbpuqRM5BVTdt8D/nroJJJ+pvb7AlsRrXPAuIC0myM7LV0 3wNe4cEJy6AciHSU3Yclqro5Q/NtpQYrHx1jk+otLJ6HRA8F6sLoSA1W6sR3IlKFWdFU pXj3HXY4ZeKFsLaHcyNGU8iJuJRXpK5iStjvnQ/hCMRDcoWRo1yt9/Ul4p5v89rvZOtg ofo46hHHOOFXEI1fBRbJcv04ijH9STR+9dtDfpNjIXGofRXBxQa0onMAhEcZRSGKGQTh +Uqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=W/gBOMdXvY54Ce4szYMBZ8OIQP2/CQxDAHTzVr7o5/c=; b=M38kiIazkWmckuJOeTyAF7tSVjndUYYBFdoj9maLMMHZWMCgh55mySDw9KWaGNJU2B nfIr6ln24Kz7MjiR9h0FT0bw1f2S+S30rBbnzlAbU1bXaDQvphZwtc9wfEbGvZrgEqcg ycceRdbI2lltG7fraGFo+ar9iOjckQMAAtSYDbYA6N8Euogs5i6hcezLJX7yKDBGQ8JI pPLGzkcH9VDVlahC/fW4SGc8kxLUJXQDf8B/daV0pqM763Nhp72vjLro+4ZGhQM7zB4a PZ2qBcORhOFgEfRt4jkrE8nLmbkugKKSnKy/XgFdUWi1FayXgHHYSwrZ3Fm9ky2nnepv 9GnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lv13si413143ejb.290.2020.11.19.04.52.48; Thu, 19 Nov 2020 04:53:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbgKSMsZ (ORCPT + 99 others); Thu, 19 Nov 2020 07:48:25 -0500 Received: from elvis.franken.de ([193.175.24.41]:43147 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgKSMsZ (ORCPT ); Thu, 19 Nov 2020 07:48:25 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kfjK0-0004vb-01; Thu, 19 Nov 2020 13:45:56 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 74374C020B; Thu, 19 Nov 2020 13:45:44 +0100 (CET) Date: Thu, 19 Nov 2020 13:45:44 +0100 From: Thomas Bogendoerfer To: Jinyang He Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] MIPS: KASLR: Make relocation_address can be configured Message-ID: <20201119124544.GB4936@alpha.franken.de> References: <1605752954-10368-1-git-send-email-hejinyang@loongson.cn> <1605752954-10368-3-git-send-email-hejinyang@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605752954-10368-3-git-send-email-hejinyang@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2020 at 10:29:14AM +0800, Jinyang He wrote: > When CONFIG_RANDOMIZE_BASE is not set, determine_relocation_address() > always returns a constant. It is not friendly to users if the address > cannot be used. Make it can be configured at Kconfig. and how do I get the information which address I need to enter ? This looks more like platforms need to supply a working address and not the user configuring the kernel... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]