Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Nov 2020 14:03:59 +0000
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     netdev@vger.kernel.org, Jorgen Hansen <jhansen@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dexuan Cui <decui@microsoft.com>,
        Anthony Liguori <aliguori@amazon.com>,
        David Duncan <davdunc@amazon.com>,
        Andra Paraschiv <andraprs@amazon.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Alexander Graf <graf@amazon.de>
Subject: Re: [PATCH net] vsock: forward all packets to the host when no H2G
 is registered
Message-ID: <20201119140359.GE838210@stefanha-x1.localdomain>
References: <20201112133837.34183-1-sgarzare@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20201112133837.34183-1-sgarzare@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="LSp5EJdfMPwZcMS1"
Content-Disposition: inline
Precedence: bulk

--LSp5EJdfMPwZcMS1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 12, 2020 at 02:38:37PM +0100, Stefano Garzarella wrote:
> Before commit c0cfa2d8a788 ("vsock: add multi-transports support"),
> if a G2H transport was loaded (e.g. virtio transport), every packets
> was forwarded to the host, regardless of the destination CID.
> The H2G transports implemented until then (vhost-vsock, VMCI) always
> responded with an error, if the destination CID was not
> VMADDR_CID_HOST.
>=20
> From that commit, we are using the remote CID to decide which
> transport to use, so packets with remote CID > VMADDR_CID_HOST(2)
> are sent only through H2G transport. If no H2G is available, packets
> are discarded directly in the guest.
>=20
> Some use cases (e.g. Nitro Enclaves [1]) rely on the old behaviour
> to implement sibling VMs communication, so we restore the old
> behavior when no H2G is registered.
> It will be up to the host to discard packets if the destination is
> not the right one. As it was already implemented before adding
> multi-transport support.
>=20
> Tested with nested QEMU/KVM by me and Nitro Enclaves by Andra.
>=20
> [1] Documentation/virt/ne_overview.rst
>=20
> Cc: Jorgen Hansen <jhansen@vmware.com>
> Cc: Dexuan Cui <decui@microsoft.com>
> Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
> Reported-by: Andra Paraschiv <andraprs@amazon.com>
> Tested-by: Andra Paraschiv <andraprs@amazon.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  net/vmw_vsock/af_vsock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

--LSp5EJdfMPwZcMS1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl+2e08ACgkQnKSrs4Gr
c8jnpAf/ZlfAs5UL1VEQIlS5BEGEE+bicGoAleU1Yh5k7eUzzORP8xdTs4yYcgFL
/xMVz10txbvI76GY3XmqVo6Ozo59vb6fpitwugFkKaj68PtFvrtYphdEEcbr8zXz
K6/5OXeODb/V+7ZGTmXaJbBwQt7gUpTPaDdIqRVg+IPySeVPFv3AFuO8CnUb9h6u
zJ+ApyCa286w8y8ZuUv14QZ2hVxh6GxSt7VM8Z0iMCLzv3HwQc/esv1A2Hpx+OFv
qAaR8olM9gZ4jdWMBWaPL6pWQ2EPqeLCsb4bAOfGdb2+4oVyk/Um/AKiOaCzt+D1
3aEgST74NbQjYmSzdWDr9pknnxCeyw==
=YQlg
-----END PGP SIGNATURE-----

--LSp5EJdfMPwZcMS1--