Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp486440pxb; Thu, 19 Nov 2020 06:26:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRxS0LNOzdJ+aM+03ZzzsJMHNAcghoLjQ4SZc/WOhhFfwePewyFENO9l92zYG/BioTYojC X-Received: by 2002:a17:906:f881:: with SMTP id lg1mr2103757ejb.133.1605795964490; Thu, 19 Nov 2020 06:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605795964; cv=none; d=google.com; s=arc-20160816; b=wmtFRXmBBi+ipbLfx3MEkAs3rb5clsqzfDh8YaNunELHtvikXJgr5K/5RhGydSoI/s n8CNjuTtWnSTdhwrVYEtRO5vbgzvTou+ybRRKYB6rBX/aTL3Fse0QvmZkrQUYe4Zxrvv 9+i70FxGA1SKXUhr9noeldT73NWd9OpIzGFnZT9duoVEJsjkQV/5PVsNIM3RTyvy6M9B PXSeEVNNNPNeJTzDdq3SnCgLo0nbYo/6C7hZUCkDQjvPBUoMuZ9OxUNyDMtk7mjKBrFh TaXZOf+mA6ub1o44mEuSN8HZ0mdFad6AXBa1iBpq5N+tD7Jud/BbGpClxH6XwYbHOusW 6H0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=x0JReUeONoCxKDJYPQnrL6Sz+i2rApTdJsmnhbQywvE=; b=NeU8bcZkrZjnEmRizSmXNHuNznRpBfhujOM2y6FfFldC4M+VGk7EtWIfepmZ6K70sb peGoVgrZmShCb+Zngipb/RW8lkDZLALBNxFEA062UjPX/L7NrmAm09PVab6OL7zJCG+G tWK7TW6/fww2SmebzHtMNaXK7d/NK4VZg6IkMeVRh8wnujSOAZCir7y+dzyqGzug/rei doZxe2RABIDJBwsadc0akq7TGzNcNL8hdWD6FPjL2hFtpYSjtu4mW54NL/4KYLzPBTcl Py6P+OHz+Zos1DSNSuLQSQYm4PynwJpUcus72w73nJUSNfw9I+JrLy3HU4I2yo5fK1XW z2aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i59si17837999edd.308.2020.11.19.06.25.40; Thu, 19 Nov 2020 06:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbgKSOWL (ORCPT + 99 others); Thu, 19 Nov 2020 09:22:11 -0500 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:45448 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKSOWL (ORCPT ); Thu, 19 Nov 2020 09:22:11 -0500 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AJEEP5M029003; Thu, 19 Nov 2020 09:22:09 -0500 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com with ESMTP id 34t9ybt8r3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Nov 2020 09:22:09 -0500 Received: from SCSQMBX10.ad.analog.com (SCSQMBX10.ad.analog.com [10.77.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 0AJEM72U029589 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Thu, 19 Nov 2020 09:22:07 -0500 Received: from SCSQCASHYB7.ad.analog.com (10.77.17.133) by SCSQMBX10.ad.analog.com (10.77.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Thu, 19 Nov 2020 06:22:06 -0800 Received: from SCSQMBX11.ad.analog.com (10.77.17.10) by SCSQCASHYB7.ad.analog.com (10.77.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Thu, 19 Nov 2020 06:22:05 -0800 Received: from zeus.spd.analog.com (10.66.68.11) by SCSQMBX11.ad.analog.com (10.77.17.10) with Microsoft SMTP Server id 15.1.1779.2 via Frontend Transport; Thu, 19 Nov 2020 06:22:05 -0800 Received: from localhost.localdomain ([10.48.65.12]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 0AJEM2kQ028442; Thu, 19 Nov 2020 09:22:02 -0500 From: Alexandru Ardelean To: , CC: , , Alexandru Ardelean Subject: [PATCH] iio: adc: ad7292: remove unneeded spi_set_drvdata() Date: Thu, 19 Nov 2020 16:27:20 +0200 Message-ID: <20201119142720.86326-1-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-19_09:2020-11-19,2020-11-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011190107 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This seems to have been copied from a driver that calls spi_set_drvdata() but doesn't call spi_get_drvdata(). Setting a private object on the SPI device's object isn't necessary if it won't be accessed. This change removes the spi_set_drvdata() call. Signed-off-by: Alexandru Ardelean --- drivers/iio/adc/ad7292.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c index ab204e9199e9..70e33dd1c9f7 100644 --- a/drivers/iio/adc/ad7292.c +++ b/drivers/iio/adc/ad7292.c @@ -276,8 +276,6 @@ static int ad7292_probe(struct spi_device *spi) return -EINVAL; } - spi_set_drvdata(spi, indio_dev); - st->reg = devm_regulator_get_optional(&spi->dev, "vref"); if (!IS_ERR(st->reg)) { ret = regulator_enable(st->reg); -- 2.17.1