Subject: Re: [PATCH] BLOCK: Make it possible to disable the block layer
From: David Woodhouse <dwmw2@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Jens Axboe <axboe@suse.de>, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <32640.1156424442@warthog.cambridge.redhat.com>
References: <32640.1156424442@warthog.cambridge.redhat.com>
Content-Type: text/plain
Date: Thu, 24 Aug 2006 14:13:13 +0100
Message-Id: <1156425193.3012.32.camel@pmac.infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1290
Lines: 34

On Thu, 2006-08-24 at 14:00 +0100, David Howells wrote:
> Make it possible to disable the block layer.  Not all embedded devices require
> it, some can make do with just JFFS2, NFS, ramfs, etc - none of which require
> the block layer to be present.
> 
> This patch does the following:
> 
>  (*) Introduces CONFIG_BLOCK to disable the block layer, buffering and blockdev
>      support.

Excellent -- I've been meaning to do this (and occasionally hacking on
it half-heartedly before getting distracted by something else shiny) for
a _long_ time.

It looks good in general.

>  (*) The contents of a number of filesystem- and blockdev-specific header files
>      are now contingent on their own configuration options.  This includes:
>      Ext3/JBD, RAID, MSDOS and ReiserFS.

Why? Those header files shouldn't be included from anywhere _but_ the
code in question, and in fact should probably be just moved into fs/foo
instead of living in include/linux/foo_fs.h. 

And please, _never_ make anything dependent on CONFIG_foo_MODULE.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/