Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201119142104.85566-1-alexandru.ardelean@analog.com>
In-Reply-To: <20201119142104.85566-1-alexandru.ardelean@analog.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 19 Nov 2020 17:05:21 +0200
Message-ID: <CAHp75VdkomLMPYZbB7-KerGmyxXxB8hQuAjLtJ0bhB5f5vfuNA@mail.gmail.com>
Subject: Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()
To:     Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nandor Han <nandor.han@ge.com>,
        Semi Malinen <semi.malinen@ge.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean
<alexandru.ardelean@analog.com> wrote:
>
> There is no matching spi_get_drvdata() call in the driver, so there is no
> need to do spi_set_drvdata(). This looks like it probably was copied from a
> driver that used both spi_set_drvdata() & spi_get_drvdata().

While above luckily (*) okay it may not always be the case.

*) it can be paired with dev_get_drvdata() which is usual for PM callbacks.

With amended commit message
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
>  drivers/gpio/gpio-xra1403.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
> index e2cac12092af..49c878cfd5c6 100644
> --- a/drivers/gpio/gpio-xra1403.c
> +++ b/drivers/gpio/gpio-xra1403.c
> @@ -186,15 +186,7 @@ static int xra1403_probe(struct spi_device *spi)
>                 return ret;
>         }
>
> -       ret = devm_gpiochip_add_data(&spi->dev, &xra->chip, xra);
> -       if (ret < 0) {
> -               dev_err(&spi->dev, "Unable to register gpiochip\n");
> -               return ret;
> -       }
> -
> -       spi_set_drvdata(spi, xra);
> -
> -       return 0;
> +       return devm_gpiochip_add_data(&spi->dev, &xra->chip, xra);
>  }
>
>  static const struct spi_device_id xra1403_ids[] = {
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko