Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     salyzyn@google.com, kernel-team@android.com,
        nguyenb@codeaurora.org, hongwus@codeaurora.org,
        saravanak@google.com, asutoshd@codeaurora.org,
        Can Guo <cang@codeaurora.org>, rnayak@codeaurora.org,
        linux-scsi@vger.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        Avri Altman <avri.altman@wdc.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        open list <linux-kernel@vger.kernel.org>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Alim Akhtar <alim.akhtar@samsung.com>
Subject: Re: [PATCH] scsi: ufs: Make sure clk scaling happens only when hba is runtime ACTIVE
Date:   Thu, 19 Nov 2020 10:03:41 -0500
Message-Id: <160579821161.27938.15426150263135159232.b4-ty@oracle.com>
In-Reply-To: <1600758548-28576-1-git-send-email-cang@codeaurora.org>
References: <1600758548-28576-1-git-send-email-cang@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 22 Sep 2020 00:09:04 -0700, Can Guo wrote:

> If someone plays with the UFS clk scaling devfreq governor through sysfs,
> ufshcd_devfreq_scale may be called even when hba is not runtime ACTIVE,
> which can lead to unexpected error. We cannot just protect it by calling
> pm_runtime_get_sync, because that may cause racing problem since hba
> runtime suspend ops needs to suspend clk scaling. In order to fix it, call
> pm_runtime_get_noresume and check hba's runtime status, then only proceed
> if hba is runtime ACTIVE, otherwise just bail.
> 
> [...]

Applied to 5.10/scsi-fixes, thanks!

[1/1] scsi: ufs: Make sure clk scaling happens only when HBA is runtime ACTIVE
      https://git.kernel.org/mkp/scsi/c/73cc291c2702

-- 
Martin K. Petersen	Oracle Linux Engineering