Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp517092pxb; Thu, 19 Nov 2020 07:08:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGDtJByuFWVWGnod9KoL0qfyCc74nYWNDgJMrUaiTT2mZmWVqHLGzblr0nzvmKZW3wohUC X-Received: by 2002:a50:951e:: with SMTP id u30mr32834571eda.197.1605798531772; Thu, 19 Nov 2020 07:08:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605798531; cv=none; d=google.com; s=arc-20160816; b=YXiT+8ZjLSxz0+VIkVHp/OmmP8mquEcIBkrlWTIG4lLPodYE+FBQzRO+/OzmPKHtzm 7rEdoG29kw/zeH8dZ2cmuE96FnEi2vrkxC1NUGpop0BxKtcijp9bFS4nqga8zdaJCJyg az0t8Kak/yM/0tXQRORpaI8Uo3J3T7ijxaJZOx9cSaLMnocEWb4Fat+nu7w3Wf6vek0Q ITRN1TJuHFHUWx7Ei3vXRlkIxdmt2s9BRQeHGM1LRDhi3+FAkA4+Pl2OggKi7FytguPG 3S66H03rOX4+igdcpdasJRWnJYYrs5uai2u/7Y8KLVgbQuDrlx38bzzZ0JGlPoN2Zilv IFrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=698JySp1SeXV+YubtoacJTUwxrI0tGvgTfAK1MnErAs=; b=hHqv18/LVIyASG6fiwSrvk+KznQnrH3JkXgsR9uVQDYYsji4NfprwPT1M4NLZUX5kl uw/oTZcPEegDbNo/FmCuPlrfEXd5R0Ns6ftFKGZWQ6T63qduxA4kzzdupL+/6fV0tEPD drZlD/02U6NnuUkgcUugPHAK9qtJW57xZkRKyk/bVeFOFUPfsiO4mMwKLvQHtfMF2L/D zDHfdxlaDK4AnChY+Hrqre51t6JXPWklA1QKSGsJZe1x7atl72Cxaf0m/9J/uADslhER qePlL4GZdAkxlroWvZTG9VQZuLdCYFb7SrIYL9ngcKV439Tt5iurz6485gX2SUZyL2W4 UaXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=V3g2wOze; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec4si17595739ejb.549.2020.11.19.07.08.25; Thu, 19 Nov 2020 07:08:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=V3g2wOze; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728094AbgKSPEU (ORCPT + 99 others); Thu, 19 Nov 2020 10:04:20 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:58074 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727309AbgKSPEU (ORCPT ); Thu, 19 Nov 2020 10:04:20 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AJEsNT7178525; Thu, 19 Nov 2020 15:03:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=698JySp1SeXV+YubtoacJTUwxrI0tGvgTfAK1MnErAs=; b=V3g2wOzeK+XtCHOWXcjII0yj3YBOCGdDQ9s8g9HWcmBwXWgKrdY9T8De75dWRMjRe0bz wJqYCjB7YdNxG9NvS1izn2/EwO+aM46mfH6iJWSnyhXN6npwk6nIFwL5+dvLxElSLSH2 X+fedRm3eORsSWmeAAFdlwDGMk5U+1bgD2VmnGixpC9WXlaudae+tDat9uV1ymmAOPpp 9qwqAPit/344oXTz05uwaMm8zZR5Ry94k8avk7YwKthW7hEdwV2TlkVAxT+oOz+5wdby 9iT+YFCIH43TEzMOzDGDt3KXtmLpuO8EeCJzA2nfU6w0n9BuuAHMD/6RVXOSiLyYEJ0f cg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 34t76m5uek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Nov 2020 15:03:48 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AJEsdGG056602; Thu, 19 Nov 2020 15:03:48 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 34ts602v40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Nov 2020 15:03:47 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AJF3jYQ022090; Thu, 19 Nov 2020 15:03:45 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 19 Nov 2020 07:03:45 -0800 From: "Martin K. Petersen" To: salyzyn@google.com, kernel-team@android.com, asutoshd@codeaurora.org, hongwus@codeaurora.org, saravanak@google.com, nguyenb@codeaurora.org, Can Guo , rnayak@codeaurora.org, linux-scsi@vger.kernel.org Cc: "Martin K . Petersen" , Avri Altman , Stanley Chu , "James E.J. Bottomley" , Bean Huo , open list , Bart Van Assche , Alim Akhtar Subject: Re: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param() Date: Thu, 19 Nov 2020 10:03:42 -0500 Message-Id: <160579821160.27938.2855666994784444501.b4-ty@oracle.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <1603346348-14149-1-git-send-email-cang@codeaurora.org> References: <1603346348-14149-1-git-send-email-cang@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9809 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011190113 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9809 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011190113 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Oct 2020 22:59:00 -0700, Can Guo wrote: > Since WB feature has been added, WB related sysfs entries can be accessed > even when an UFS device does not support WB feature. In that case, the > descriptors which are not supported by the UFS device may be wrongly > reported when they are accessed from their corrsponding sysfs entries. > Fix it by adding a sanity check of parameter offset against the actual > decriptor length. Applied to 5.10/scsi-fixes, thanks! [1/1] scsi: ufs: Fix unexpected values from ufshcd_read_desc_param() https://git.kernel.org/mkp/scsi/c/1699f980d87f -- Martin K. Petersen Oracle Linux Engineering