Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 16gkPpprIQTxa5ynhEfVQWC4Gfw7i2jIDSutdaMM8o4gxJ33t6tzAS7XGnBZvgqxBNPHXvZv3P
 qaXVPgsZ70lQ==
IronPort-SDR: iSchIvvKK82twu/wnA3A21/yAi2w577jmVsHprnWNLy6hJ4eNVp5eYk1uU+7yZKI60QgoIkXKC
 rzjHENa9MwHg==
Date:   Thu, 19 Nov 2020 18:10:51 +0100
From:   Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To:     Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver
Message-ID: <20201119171051.GA6464@ubuntu>
References: <20201118213700.74106-1-mathieu.poirier@linaro.org>
 <20201118213700.74106-9-mathieu.poirier@linaro.org>
 <447fdbd6-2e3d-2786-c444-25148efcb9f8@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <447fdbd6-2e3d-2786-c444-25148efcb9f8@st.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Mathieu,

I haven't tested it yet, but I've compared it to the previous version 
and all the changed except the one, mentioned by Arnaud, seem to be 
there! So, let's just fix this one and should be good to go!

Thanks
Guennadi

On Thu, Nov 19, 2020 at 03:52:50PM +0100, Arnaud POULIQUEN wrote:

[snip]

> As Guennadi mentionned in a previous mail
> a kfree(vch) is missing on error
> 
> @@ -949,10 +949,11 @@ static int rpmsg_probe(struct virtio_device *vdev)
>  	dev_info(&vdev->dev, "rpmsg host is online\n");
> 
>  	return 0;
> 
>  free_coherent:
> +	kfree(vch);
>  	dma_free_coherent(vdev->dev.parent, total_buf_space,
>  			  bufs_va, vrp->bufs_dma);
>  vqs_del:
> 
> Otherwise i tested this series successfully.
> 
> Thanks,
> Arnaud