Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Nov 2020 10:33:32 -0700
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Cc:     Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver
Message-ID: <20201119173332.GA94178@xps15>
References: <20201118213700.74106-1-mathieu.poirier@linaro.org>
 <20201118213700.74106-9-mathieu.poirier@linaro.org>
 <447fdbd6-2e3d-2786-c444-25148efcb9f8@st.com>
 <20201119171051.GA6464@ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201119171051.GA6464@ubuntu>
Precedence: bulk

On Thu, Nov 19, 2020 at 06:10:51PM +0100, Guennadi Liakhovetski wrote:
> Hi Mathieu,
> 
> I haven't tested it yet, but I've compared it to the previous version 
> and all the changed except the one, mentioned by Arnaud, seem to be 
> there! So, let's just fix this one and should be good to go!
>

Apologies for the brain bug - the code got lost in the thread...
 
> Thanks
> Guennadi
> 
> On Thu, Nov 19, 2020 at 03:52:50PM +0100, Arnaud POULIQUEN wrote:
> 
> [snip]
> 
> > As Guennadi mentionned in a previous mail
> > a kfree(vch) is missing on error
> > 
> > @@ -949,10 +949,11 @@ static int rpmsg_probe(struct virtio_device *vdev)
> >  	dev_info(&vdev->dev, "rpmsg host is online\n");
> > 
> >  	return 0;
> > 
> >  free_coherent:
> > +	kfree(vch);
> >  	dma_free_coherent(vdev->dev.parent, total_buf_space,
> >  			  bufs_va, vrp->bufs_dma);
> >  vqs_del:
> > 
> > Otherwise i tested this series successfully.
> > 
> > Thanks,
> > Arnaud