Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Nov 2020 18:03:15 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] eventfd: convert to ->write_iter()
Message-ID: <20201119180315.GB24054@infradead.org>
References: <ed4484a3dc8297296bfcd16810f7dc1976d6f7d0.1605808477.git.mkubecek@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ed4484a3dc8297296bfcd16810f7dc1976d6f7d0.1605808477.git.mkubecek@suse.cz>
Precedence: bulk

On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote:
> While eventfd ->read() callback was replaced by ->read_iter() recently by
> commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write()
> was not replaced.
> 
> Convert also ->write() to ->write_iter() to make the interface more
> consistent and allow non-blocking writes from e.g. io_uring. Also
> reorganize the code and return value handling in a similar way as it was
> done in eventfd_read().

But this patch does not allow non-blocking writes.  I'm really
suspicious as you're obviously trying to hide something from us.