Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Nov 2020 19:46:10 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] eventfd: convert to ->write_iter()
Message-ID: <20201119184610.sxc7utcsfwsqvwu5@lion.mk-sys.cz>
References: <ed4484a3dc8297296bfcd16810f7dc1976d6f7d0.1605808477.git.mkubecek@suse.cz>
 <20201119180315.GB24054@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201119180315.GB24054@infradead.org>
Precedence: bulk

On Thu, Nov 19, 2020 at 06:03:15PM +0000, Christoph Hellwig wrote:
> On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote:
> > While eventfd ->read() callback was replaced by ->read_iter() recently by
> > commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write()
> > was not replaced.
> > 
> > Convert also ->write() to ->write_iter() to make the interface more
> > consistent and allow non-blocking writes from e.g. io_uring. Also
> > reorganize the code and return value handling in a similar way as it was
> > done in eventfd_read().
> 
> But this patch does not allow non-blocking writes.  I'm really
> suspicious as you're obviously trying to hide something from us.

I already explained what my original motivation was and explained that
it's no longer the case as the third party module that inspired me to
take a look at this can be easily patched not to need kernel_write() to
eventfd - and that it almost certainly will have to be patched that way
anyway. BtW, the reason I did not mention out of tree modules in the
commit message was exactly this: I suspected that any mention of them
could be a red flag for some people.

I believed - and I still believe - that this patch is useful for other
reasons and Jens added another. Therefore I resubmitted with commit
message rewritten as requested, even if I don't need it personally. I'm
not hiding anything and I don't have time for playing your political
games and suffer your attacks. If they are more important than improving
kernel code, so be it. I'm annoyed enough and I don't care any more.

Michal Kubecek