Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201118025503.102699-1-bernard@vivo.com> <f55ec782-9eff-c30b-2a0e-01a9898c9387@amd.com>
In-Reply-To: <f55ec782-9eff-c30b-2a0e-01a9898c9387@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 19 Nov 2020 16:56:44 -0500
Message-ID: <CADnq5_Pnv7+vu-mV3C5-zKXFexzs=qX6Jne6DKx-LteP_VQn-Q@mail.gmail.com>
Subject: Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Bernard Zhao <bernard@vivo.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Monk Liu <Monk.Liu@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Yintian Tao <yttao@amd.com>, Dennis Li <Dennis.Li@amd.com>,
        Wenhui Sheng <Wenhui.Sheng@amd.com>,
        chen gong <curry.gong@amd.com>,
        Bokun Zhang <Bokun.Zhang@amd.com>,
        "Stanley.Yang" <Stanley.Yang@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Nov 18, 2020 at 3:18 AM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
>
> Am 18.11.20 um 03:55 schrieb Bernard Zhao:
> > Fix check_patch.pl warning:
> > WARNING: Prefer kmalloc_array over kmalloc with multiply
> > +bps =3D kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> > WARNING: Prefer kmalloc_array over kmalloc with multiply
> > +bps_bo =3D kmalloc(align_space * sizeof((*data)->bps_bo),
> > GFP_KERNEL);
> > kmalloc_array has multiply overflow check, which will be safer.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Not userspace controllable values, but looks cleaner anyway.
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm=
/amd/amdgpu/amdgpu_virt.c
> > index d0aea5e39531..f2a0851c804f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> > @@ -280,8 +280,8 @@ static int amdgpu_virt_init_ras_err_handler_data(st=
ruct amdgpu_device *adev)
> >       if (!*data)
> >               return -ENOMEM;
> >
> > -     bps =3D kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> > -     bps_bo =3D kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KER=
NEL);
> > +     bps =3D kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERN=
EL);
> > +     bps_bo =3D kmalloc_array(align_space, sizeof((*data)->bps_bo), GF=
P_KERNEL);
> >
> >       if (!bps || !bps_bo) {
> >               kfree(bps);
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel