Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wtBvjoRb7IDzUBPZ1ChmQGNGL/YuroMhwLBj4LV8SAVCZlmrEkZ/Ygz/yguG2k/O+wP7jsCPGu
 dQpwHyj1Enzg==
IronPort-SDR: NAuq667yFYMEkEwZNtP5rvIie1z4KB/ESFq08FwHV6AqvBE0Eo6IzOd8P86yBmBhTKI72mg9X5
 5z4cjh3MS7KQ==
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     Prashant Malani <pmalani@chromium.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "Mani, Rajmohan" <rajmohan.mani@intel.com>,
        "Shaikh, Azhar" <azhar.shaikh@intel.com>
Subject: RE: [PATCH v3 2/4] platform/chrome: cros_ec_typec: Use Thunderbolt 3
 cable discover mode VDO in USB4 mode
Thread-Topic: [PATCH v3 2/4] platform/chrome: cros_ec_typec: Use Thunderbolt 3
 cable discover mode VDO in USB4 mode
Thread-Index: AQHWvj38P4aA1Z7OikiHPeCCNaPmQ6nPGgQAgAEtF2A=
Date:   Fri, 20 Nov 2020 02:32:24 +0000
Message-ID: <MWHPR11MB004898556A4CF622742D3EAAA9FF0@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20201119063211.2264-1-utkarsh.h.patel@intel.com>
 <20201119063211.2264-3-utkarsh.h.patel@intel.com>
 <20201119080906.GE3652649@google.com>
In-Reply-To: <20201119080906.GE3652649@google.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c1ba90-e87e-41e0-607f-08d88cfc83a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2020 02:32:24.0325
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iltgLUZs7Yvz48RHeQkOmlBh41GVvLwMVScnuV0LD7zofjZBH9UH68NmF7EDoJfPVSA7ukgP3DPPCQNPig5TFB688+7TFmvFqyHXFAEaBlE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1437
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Prashant,

> -----Original Message-----
> From: Prashant Malani <pmalani@chromium.org>
> Sent: Thursday, November 19, 2020 12:09 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org;
> heikki.krogerus@linux.intel.com; enric.balletbo@collabora.com; Mani,
> Rajmohan <rajmohan.mani@intel.com>; Shaikh, Azhar
> <azhar.shaikh@intel.com>
> Subject: Re: [PATCH v3 2/4] platform/chrome: cros_ec_typec: Use Thunderbo=
lt
> 3 cable discover mode VDO in USB4 mode
>=20
> Hi Utkarsh,
>=20
> On Wed, Nov 18, 2020 at 10:32:09PM -0800, Utkarsh Patel wrote:
> > Configure Thunderbolt 3 cable generation value by filling Thunderbolt
> > 3 cable discover mode VDO to support rounded Thunderbolt 3 cables.
> > While we are here use Thunderbolt 3 cable discover mode VDO to fill
> > active cable plug link training value.
> >
> > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> >
> > --
> > Changes in v3:
> > - Added a check for cable's TBT support before filling TBT3 discover mo=
de
> >   VDO.
> >
> > Changes in v2:
> > - No change.
> > --
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c
> > b/drivers/platform/chrome/cros_ec_typec.c
> > index 8111ed1fc574..68b17ee1d1ae 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -514,8 +514,18 @@ static int cros_typec_enable_usb4(struct
> cros_typec_data *typec,
> >  	else if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE)
> >  		data.eudo |=3D EUDO_CABLE_TYPE_RE_TIMER <<
> EUDO_CABLE_TYPE_SHIFT;
> >
> > -	data.active_link_training =3D !!(pd_ctrl->control_flags &
> > -				       USB_PD_CTRL_ACTIVE_LINK_UNIDIR);
> > +	/*
> > +	 * Filling TBT3 Cable VDO when TBT3 cable is being used to establish
> > +	 * USB4 connection.
> > +	 */
> > +	if (pd_ctrl->cable_gen) {
> > +		data.tbt_cable_vdo =3D TBT_MODE;
> > +
> > +		if (pd_ctrl->control_flags &
> USB_PD_CTRL_ACTIVE_LINK_UNIDIR)
> > +			data.tbt_cable_vdo |=3D TBT_CABLE_LINK_TRAINING;
> > +
> > +		data.tbt_cable_vdo |=3D TBT_SET_CABLE_ROUNDED(pd_ctrl-
> >cable_gen);
> > +	}
>=20
> I think the following would decouple Rounded Support and Active Cable Lin=
k
> Training?:

Any reason you would want to decouple them?
As for the TBT3 active cable to create USB4 connection, it needs have round=
ed data rates.=20

>=20
> 	struct typec_thunderbolt_data data =3D {}; ...
> 	if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR)
> 		data.tbt_cable_vdo |=3D TBT_CABLE_LINK_TRAINING;
>=20
> 	data.tbt_cable_vdo |=3D TBT_SET_CABLE_ROUNDED(pd_ctrl-
> >cable_gen);
>=20
> 	if (data.tbt_cable_vdo)
> 		data.tbt_cable_vdo |=3D TBT_MODE;
>=20
>=20
> Best regards,
>=20
> -Prashant

Sincerely,
Utkarsh Patel.