Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp958253pxb; Thu, 19 Nov 2020 19:16:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzU2JFLmr/aR8LTbpox4zoV7gJSGZzh1kIu8sqFxR3zoxkInkN6ngIIBfbr3pGzTTmTqrbv X-Received: by 2002:a05:6402:1456:: with SMTP id d22mr32853710edx.77.1605842187790; Thu, 19 Nov 2020 19:16:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605842187; cv=none; d=google.com; s=arc-20160816; b=QYl+Mxi6G77Ta0eu+lZY0rPHBleLwtC1/PTdzyJ1ZTR8O4DNnHZHFNbgMCyHnIhz8g 3ZoxQFD3r+gQXa+vIJ3kNfLPqhRi13Lp2ptyyD7I39NEXOlhc9pRHNdHsQhjDItziiaJ JgXJGvNVH2UYsWIhoK5MMx0tCNDJ+wet21pPJ7NagGRump3uU1eIUbmJZ9beEgc+lqYH 8EPLyd0PlhBlX4fanqEkJDi/C+R/Yr91SHvxuED/ZWLtMjJzSP5/xmkXboJMY1HaJ9C8 MoCfNXVR2uOjxO2Bl2CdJQrGEexU34c8oTeiT6oABV33aKqyvMacqyumMqv4g/nWoFHh QyRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=s/8N3xCSQsdW1nxIK6iFS39cuZ3X3S3099X+yNSwVNY=; b=JIK2YDzXITRo//AO5uBL7lHlBDKUqnAB4gIhTqUSiMQkCs8n/6KCJClfF2TJPSHXjK n+bsDCve7SyUeKwZlR0eUbhqm0OQRRIGw6hbFWMLC3QCeHcj0YwL1WHvj91q6XUuUXxg W6EFoCLK+4h5+Mfc2pnmI3agTxrLXHqnf1KqfuGrqJ5VPVImm5KuMgFQE6W8Pgxv+aF4 sW3HGMSFGMi0NwJsjmI49atoIv3uVIHXiHKEI6uVx9zT+ldpspMeiEqLwJKQMbnDfcX7 sJnuWsOJWom47XaW8Aelml2/fhaaV9n161fWUJGNJxx5wMMM5fvGNa+iOf2ZCBSwulkS K7+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=UNyZAqzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oo20si960081ejb.400.2020.11.19.19.16.04; Thu, 19 Nov 2020 19:16:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=UNyZAqzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgKTDOL (ORCPT + 99 others); Thu, 19 Nov 2020 22:14:11 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:35480 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgKTDOL (ORCPT ); Thu, 19 Nov 2020 22:14:11 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AK3AOfF044941; Fri, 20 Nov 2020 03:14:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=s/8N3xCSQsdW1nxIK6iFS39cuZ3X3S3099X+yNSwVNY=; b=UNyZAqzNHYbh92DyeBhBKycv3nrnu/v4KNDn6BoUqSe1Lidew3RZvORL40otx1NnnKR+ 1R3atx06DUJUTMxloGzWN1LdgFygK3KdelvDdREaYD8LNyIUmOiNkY0vZjwDgTpscGLW QuA8/GoJ82t5O4IoUyHhjDuT1cycDp6OFYe6uDzZiN13fl9PeJH2QNV+4jdAEED5sJmQ h5lDzb7rexe0DbLMcROYhHrAFutM4F9v9jWHJBcU/PdS+txexRsTx0z7St+P6deJ3Vem ajtjtFCDMJ48UrMrlu+VEh34zKY2B98O5SQQtdC9mLKdcCOYUQej6gI+TnK000lnDRxs OQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 34t4rb8t00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Nov 2020 03:14:05 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AK35iaK166566; Fri, 20 Nov 2020 03:14:04 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 34uspx1ycv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Nov 2020 03:14:04 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AK3E3jp021197; Fri, 20 Nov 2020 03:14:03 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 19 Nov 2020 19:14:03 -0800 To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201118131345.460631-1-colin.king@canonical.com> Date: Thu, 19 Nov 2020 22:14:01 -0500 In-Reply-To: <20201118131345.460631-1-colin.king@canonical.com> (Colin King's message of "Wed, 18 Nov 2020 13:13:45 +0000") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9810 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=1 adultscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200022 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9810 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1011 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=1 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200022 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > There is a null check on pointer lpfc_cmd after the pointer has been > dereferenced when pointers rdata and ndlp are initialized at the start > of the function. Fix this by only assigning rdata and ndlp after the > pointer lpfc_cmd has been null checked. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering