Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp966102pxb; Thu, 19 Nov 2020 19:35:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWVuK/twlklQV6ePhgjl0heu/6Gp58WmF7AvUn04g7rgwC3+vp2gv2LiJvZitBEpMLLW2j X-Received: by 2002:a17:906:3acd:: with SMTP id z13mr31726009ejd.118.1605843303012; Thu, 19 Nov 2020 19:35:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605843303; cv=none; d=google.com; s=arc-20160816; b=YoiKRzikjjpyXzA56eWO21Gv0u9z+INsQgiybfBx22ekqK/ojkTl/3phAdyvUt9f4m C3p0UG8Lo0bVVWxQ9/mu5nKy5St/1JUT1KV1xbllzup9PlNCcXt1Rle30elL4eITVoJb EqQmcMay3lpsgfa/0H3N1yp/8BQ6sND0hLHytIh34SVqmQ1+juFJx1q5VK8P70sbL+sV M4ElxVtO14VqteRyNwFeP16/jhMaEkSrbLZvaiRxjp9yud/QJdgDHJjDkbPuZr0HmEm5 12d8aUIakq2gxZG5pWeuw4l2CwSs33DSMU+EQgoCEPC6LueRv1RItzq4zT+nG6KF9oDb x3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jpMD3b1qJW/Kul31vRtcwfkmxhU26skq+zg6BUmega4=; b=UZ5lmXPEyE9RMpA5WzxV65IQs1zVzevwq+0b0kgmrLtD5i6y1bcNjSHAJX1+AtXkcq MdODPHrePkGGKv4nkD5GYku0i2sHqg0ZnCbd1VjQ2TJfZ4hXX1vhO9T6RVGQWa0mXksU 6s3yIAgR/Ursf9h+6dmX0ZqaLNipBfJEqLuCa66uUJTenvBGEAsYfE8GVvYB62yBqVH4 +9q+YsYm9UiVPxBhJ1TRw3PhhpASNtO5AqyRGBwmbKYeOBPg4+7CgRYvQaT4NpKZMcRR JXaAfp/jznSiLdRhdzPON0WK5Qp8FL9km4GGGpykuwVS/aH68WfswMQYJistivFBRxwQ D32g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=lWHAHkAD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t1si966612ejy.446.2020.11.19.19.34.40; Thu, 19 Nov 2020 19:35:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=lWHAHkAD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgKTDbE (ORCPT + 99 others); Thu, 19 Nov 2020 22:31:04 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:34300 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbgKTDbE (ORCPT ); Thu, 19 Nov 2020 22:31:04 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AK3POrJ096713; Fri, 20 Nov 2020 03:30:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jpMD3b1qJW/Kul31vRtcwfkmxhU26skq+zg6BUmega4=; b=lWHAHkAD0KmpcibgC0Z1+H2PrV/CUbDLr7rie2WaMBxfIjbR1dwusGS4rZvG/W1kP5kp tt9mQYoNNZXX+iGSciu29U6CbSQvuXQZdT6oxsl497RxZwA31oFsRvkthsZnf7XSEG3E FkKTztrFIwFclkJ2oSzL/rtkzFbO1c3TWKyNE4QlikmIHN08lVNqoZdKdnZfHk/IWKbA aQ+xuJyTXjy9hZBcPz2TG0/HleMRX+JjFEL0lgDiyKNqcjenxtnZyw6ZMb4ciDzXbCV5 Bfa6sA7qBh8qGuYlqNgicogwawemTPLGc8zPG41ctu4uWVuZcB0ji1KTvOTg6h4APdDx Gg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 34t76m8qvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Nov 2020 03:30:42 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AK3PjYv032437; Fri, 20 Nov 2020 03:30:41 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 34uspx2hq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Nov 2020 03:30:41 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0AK3UaPc017127; Fri, 20 Nov 2020 03:30:36 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 19 Nov 2020 19:30:36 -0800 From: "Martin K. Petersen" To: Stanley Chu , jejb@linux.ibm.com, alim.akhtar@samsung.com, avri.altman@wdc.com, linux-scsi@vger.kernel.org Cc: "Martin K . Petersen" , bvanassche@acm.org, cang@codeaurora.org, peter.wang@mediatek.com, asutoshd@codeaurora.org, chun-hung.wu@mediatek.com, alice.chao@mediatek.com, matthias.bgg@gmail.com, chaotian.jing@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kuohong.wang@mediatek.com, jiajie.hao@mediatek.com, linux-arm-kernel@lists.infradead.org, andy.teng@mediatek.com, beanhuo@micron.com, cc.chou@mediatek.com Subject: Re: [PATCH v1] scsi: ufs: Fix race between shutdown and runtime resume flow Date: Thu, 19 Nov 2020 22:30:34 -0500 Message-Id: <160584260540.532.6488395968913616505.b4-ty@oracle.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201119062916.12931-1-stanley.chu@mediatek.com> References: <20201119062916.12931-1-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9810 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200023 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9810 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200023 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Nov 2020 14:29:16 +0800, Stanley Chu wrote: > If UFS host device is in runtime-suspended state while > UFS shutdown callback is invoked, UFS device shall be > resumed for register accesses. Currently only UFS local > runtime resume function will be invoked to wake up the host. > This is not enough because if someone triggers runtime > resume from block layer, then race may happen between > shutdown and runtime resume flow, and finally lead to > unlocked register access. > > [...] Applied to 5.10/scsi-fixes, thanks! [1/1] scsi: ufs: Fix race between shutdown and runtime resume flow https://git.kernel.org/mkp/scsi/c/e92643db5148 -- Martin K. Petersen Oracle Linux Engineering