Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1072963pxb; Thu, 19 Nov 2020 23:47:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJymAnVJ7PaYeeBXGJ4QHCccRyJ4ygqYrF6IsV2IokMsl7wRRJ9k36TKj6PnAHShbNptZhLt X-Received: by 2002:a05:6402:a53:: with SMTP id bt19mr33733462edb.26.1605858441360; Thu, 19 Nov 2020 23:47:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605858441; cv=none; d=google.com; s=arc-20160816; b=Hdv4rAGrEtPKIKAVLnh2NOXN8iav4qyvFufyGtzyi20xOCerhygyUuI4PWpZTfzUwW iuDZIKn8DCBvx+wP5Cv/gnStv+LwLoOLWgx47tUsjG/N3JCLO3ms+KQlYdsuIuoWK0A3 EFPRcqXnR7OhiDOwZYax06Iv5O4X2fuqbdqWuQ5m2LuS6IKN/5H91t8meAG6gnODSzdS NNGRLKvEGdKymS9/ufsBsyp5+Dcnc6TNxs4VQk483vHvyxx9SMeYg7vj0I/0Uah4AOGM B2HydqQuj77vwl3/3crtfKGpiSBxLhfnpyWihcXtF9DbzXxLhdCRpg8lI3uGHAKuu4Id GAwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4lUYVqHCkryvSxD1VMxAvXJ9sxqq1uGM/+x2GICegU8=; b=FlmHoTyE7jJrV98gNe7u+1Kz/EtflopfmsOci2SmbuIwGn0yRP4wg7BIOEyDKRV50H AGojTGiUdM2qZhvCZCbq+Q8pGXTx/TJwWY+feEez4e/MX0S1H78rdQWTLHX3jsQkAXMp uQpGs2FYGNzMluXlrg0ck/i0m4inqC+edzqjgpGPbSl9y18mEi0XDlJs91Wo8isqrhlH jeYLDmu96IBQHK16c/YvSwDTl6UL3gYDVuaPw5v8oECQ4YQ6nJ/i1oNkNrbIXZiyMz79 Y2FQTQ1JApKpcKsG1OjA4c2iz3QGSs8H6F4e2eL1gcZhGb2wJfg7BNKm+ayxF9A3GU+M hgTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si1275652edi.88.2020.11.19.23.46.59; Thu, 19 Nov 2020 23:47:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbgKTHoW (ORCPT + 99 others); Fri, 20 Nov 2020 02:44:22 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8559 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbgKTHoS (ORCPT ); Fri, 20 Nov 2020 02:44:18 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CcpT51dFJzLrlb; Fri, 20 Nov 2020 15:43:53 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Nov 2020 15:44:07 +0800 From: Qinglang Miao To: Thomas Bogendoerfer , Serge Semin CC: , , "Qinglang Miao" Subject: [PATCH] mips: cdmm: fix use-after-free in mips_cdmm_bus_discover Date: Fri, 20 Nov 2020 15:48:47 +0800 Message-ID: <20201120074847.31369-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kfree(dev) has been called inside put_device so anther kfree would cause a use-after-free bug/ Fixes: 8286ae03308c ("MIPS: Add CDMM bus support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/bus/mips_cdmm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/mips_cdmm.c b/drivers/bus/mips_cdmm.c index 9f7ed1fcd..e43786c67 100644 --- a/drivers/bus/mips_cdmm.c +++ b/drivers/bus/mips_cdmm.c @@ -561,7 +561,6 @@ static void mips_cdmm_bus_discover(struct mips_cdmm_bus *bus) ret = device_register(&dev->dev); if (ret) { put_device(&dev->dev); - kfree(dev); } } } -- 2.23.0