Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201120083648.9319-1-vulab@iscas.ac.cn>
In-Reply-To: <20201120083648.9319-1-vulab@iscas.ac.cn>
From:   Jinpu Wang <jinpu.wang@cloud.ionos.com>
Date:   Fri, 20 Nov 2020 09:57:46 +0100
Message-ID: <CAMGffE=jcCppveLkaChvyk1hGWn4c8HHUouWhR2_DwKXYoradw@mail.gmail.com>
Subject: Re: [PATCH] scsi: pm8001: remove casting kcalloc
To:     Xu Wang <vulab@iscas.ac.cn>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 20, 2020 at 9:36 AM Xu Wang <vulab@iscas.ac.cn> wrote:
>
> Remove casting the values returned by kcalloc.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Thanks Xu!
> ---
>  drivers/scsi/pm8001/pm8001_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 3cf3e58b6979..ac0e598b8ac2 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1187,8 +1187,8 @@ pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost,
>                 goto err_out;
>
>         /* Memory region for ccb_info*/
> -       pm8001_ha->ccb_info = (struct pm8001_ccb_info *)
> -               kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
> +       pm8001_ha->ccb_info =
> +               kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
>         if (!pm8001_ha->ccb_info) {
>                 PM8001_FAIL_DBG(pm8001_ha, pm8001_printk
>                         ("Unable to allocate memory for ccb\n"));
> --
> 2.17.1
>