Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1123825pxb; Fri, 20 Nov 2020 01:32:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHNvLvgHwbdgznUw1yHUCEQF3BecOlYp4/s/kHDb7dkoLEKhtYLVNCQwM5ueALPQ/ZKwK5 X-Received: by 2002:a17:906:c357:: with SMTP id ci23mr30846893ejb.311.1605864749300; Fri, 20 Nov 2020 01:32:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605864749; cv=none; d=google.com; s=arc-20160816; b=HnrrEU9u6IMksyVAdEF2a8/4FwIJtXl5shQyuReODPc6a4sP+o4gisyHPdkSIg6U+q f0rrxJ7h5EdYmC9mtpuCHBX3YTUh4oCnasjYt1llV7387b2/KXKu9vBUtEhojH1iHBd+ 6J2+O1weK9E7T2pMNUvK0sP9rwsSDqI0xEYdo+UeL/8yseNcAwvTgOsYA1iDIzwpK5Tz io8XRTdD0zTcS2dTfy1Ps8cURA6XPUfo05SU33zQVfOLYXShgyg7RRtfI1Y1n0rh3IXu 81rnd0He1i5ZCvPN2/U3N/VsiUwVZPaUHjdU4PovZmfgUoC8K1nM8rlfgjUBHM5yqMyR VwwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:message-id:date:subject:cc:from; bh=P4OzeglIdzcDwmJ05JbaYkub950l7vstilXDFUgtDPA=; b=cz5/o+dpYkKdryIAvdbM7UQewVEnIOZFwSfhbXssE8X1kIcYyx1mt8Nja4JDJS+Eer dszH9FAQkyhorOnlvuUcsARn88ljBfp7WN6oCe15QDo7Y7fcOtf7ePVg4ZYjEZLIb03o WV3Uj+pcLSoNSBphK4yM4BCCwPHTXJ50gDoyu3/EMFvn6v9nw2ZRN8kUe5iBj8uG9MRt 0DM/jtzd5wZYJCbXVDDYXLqVKCvWPgIWNmXU/K6zPwxEwMY2PUEW7yhAp3EbK5I9Ckm2 EF7AVxQcm4gFPcYBevS5DrCW+D1xGN+3reu3Fkl6LRmwRuu216mwzH320f6FLmCgZAFo FLMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hb20si1377017ejc.664.2020.11.20.01.32.06; Fri, 20 Nov 2020 01:32:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbgKTJaL (ORCPT + 99 others); Fri, 20 Nov 2020 04:30:11 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:42686 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbgKTJaK (ORCPT ); Fri, 20 Nov 2020 04:30:10 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UFzA.8j_1605864606; Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UFzA.8j_1605864606) by smtp.aliyun-inc.com(127.0.0.1); Fri, 20 Nov 2020 17:30:07 +0800 From: Alex Shi Cc: Andrew Morton , Johannes Weiner , Shakeel Butt , Roman Gushchin , Michal Hocko , Yafang Shao , Alexander Duyck , Hui Su , Wei Yang , linux-kernel@vger.kernel.org Subject: [PATCH next-akpm] mm/memcg: add missed warning in mem_cgroup_lruvec Date: Fri, 20 Nov 2020 17:30:03 +0800 Message-Id: <1605864603-49118-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit "(mm/memcontrol:rewrite mem_cgroup_page_lruvec())" on mm tree use mem_cgroup_lruvec to rewrite mem_cgroup_page_lruvec, but it missed a DEBUG_VM warning as following, since we always charge a page before return from allocation. Add back this warning is helpful: VM_WARN_ON_ONCE_PAGE(!memcg, page); Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Shakeel Butt Cc: Roman Gushchin Cc: Michal Hocko Cc: Yafang Shao Cc: Alexander Duyck Cc: Hui Su Cc: Wei Yang Cc: linux-kernel@vger.kernel.org --- include/linux/memcontrol.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 925b09ace986..7809020ef7bd 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -618,6 +618,7 @@ static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg, goto out; } + VM_WARN_ON_ONCE_PAGE(!memcg, page); if (!memcg) memcg = root_mem_cgroup; -- 2.29.GIT