Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1129784pxb; Fri, 20 Nov 2020 01:44:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJynqXzwEsSU/xrW+5PyUix4jSTqqaIfFr4EDotC2mqfJjw8qSdzhGfchiIl02xXO5mvN9IP X-Received: by 2002:a17:906:3644:: with SMTP id r4mr31933396ejb.517.1605865479379; Fri, 20 Nov 2020 01:44:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605865479; cv=none; d=google.com; s=arc-20160816; b=wtsvAeh4IsUkakT6g5i0JCMET2ykzEnAbbq+zggqNcifgCLb1Hx4OdZbHhPBTwM5AQ luV7qFexaPXBoMePjFk7qTru5PZm89hWgfPldzICqTuGfCXnKUFoJL52ouCdMT0QuhGL ppjQvTwwOB3D46wDxh7aqrHKaHVoyUPuiDMEMA/FdUwJrT4Un0Bi4/PI7Ewt9WoEJt1s ejF0J2N/sj8MF6MtAD04OzMGE/Q5TqT6JSzWN/HYVkB19tNwj0tLtZlLD83WvawVMjec JrQE243+XCat9xrf29mf1KM3+5gvgH3+2nPg9XKOp4mMm9f90iGnqEtdGR+sZYp7RTqn mwFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TTlR/y5ts22LdGu11LWsJPyRwGZqfKUwRn2vCHhf1KI=; b=O/3nE1gRIFkHAdG3ja4J0/9ArAS4tSwJbTU9LjBAGu8+Du50lyoEiAU0mv0IMlLI62 rvy4RZQfspEooLl0eSqfIgF09SF1NkNliBMECrALXh+lpiPSdWGvvpimiSMvzpoKuMRW g+y05QcRkTk2bnCQOmhxC7gb5R1l8/lo8rL5JBOvekDfRprQKyXWn9WKeL9vYbqHi61w 44IUPlpJtf3omamQ6W7rSsHzNu61fLJ3C1zoIUIZeyh9AFPkiRXmj2EZW1Jr7360yYbM 0h4jWksHeEtGwrGxCOrmfkutbna/vL1EJn3bNe/cbe95GqRDY+rcN858vUC2GaRhsOwt bnpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YlefRCN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si1401154edv.480.2020.11.20.01.44.17; Fri, 20 Nov 2020 01:44:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YlefRCN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbgKTJmN (ORCPT + 99 others); Fri, 20 Nov 2020 04:42:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:52444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727160AbgKTJmM (ORCPT ); Fri, 20 Nov 2020 04:42:12 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A3AE223B0; Fri, 20 Nov 2020 09:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605865331; bh=07pOOQlCf1AGEDTz1zs87GUSSMbKSFGMWO3JJGzRHPA=; h=From:To:Cc:Subject:Date:From; b=YlefRCN3zf5t5Fs8vJbnE671oSCmica0pA8MVDzFZFPRILhxbSFH0SEBTxkqGTlrS 0Lb1thKVxN+O94OfspWVuT71QXDyXMwUvqIASQ3bafn0VjyUEQqs5S1fTOdv1f6vUG HJO5ZsKSNG5ECQB+1SgpA0GMTUByLQ9+ttnHiwmE= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kg2vh-00CDFB-6P; Fri, 20 Nov 2020 09:42:09 +0000 From: Marc Zyngier To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Martin Blumenstingl , Guillaume Tucker , kernel-team@android.com, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] More meson HDMI fixes Date: Fri, 20 Nov 2020 09:42:03 +0000 Message-Id: <20201120094205.525228-1-maz@kernel.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: narmstrong@baylibre.com, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, guillaume.tucker@collabora.com, kernel-team@android.com, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guillaume reported that my earlier fixes for the meson HDMI driver broke another set of machines which are now exploding (clock not enabled). I have thus reconsidered the approach and came up with an alternative fix (enable a missing clock), which Guillaume confirmed to be working. Jerome pointed out that this driver is leaking clock references like a sieve, so that needed addressing too. The first patch start by fixing the clock leakage using a devm facility. The second patch addresses the earlier crash by reusing the infrastructure put together in the first patch. Tested on VIM3l. Marc Zyngier (2): drm/meson: dw-hdmi: Disable clocks on driver teardown drm/meson: dw-hdmi: Enable the iahb clock early enough drivers/gpu/drm/meson/meson_dw_hdmi.c | 51 ++++++++++++++++++--------- 1 file changed, 35 insertions(+), 16 deletions(-) -- 2.28.0