Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: neeraju=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3CC94C433ED
Subject: Re: [PATCH RFC tip/core/rcu 2/5] srcu: Provide internal interface to
 start a Tiny SRCU grace period
To:     paulmck@kernel.org
Cc:     linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org,
        jiangshanlai@gmail.com, akpm@linux-foundation.org,
        mathieu.desnoyers@efficios.com, josh@joshtriplett.org,
        tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
        dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com,
        oleg@redhat.com, joel@joelfernandes.org, rcu@vger.kernel.org
References: <20201117004017.GA7444@paulmck-ThinkPad-P72>
 <20201117004052.14758-2-paulmck@kernel.org>
From:   Neeraj Upadhyay <neeraju@codeaurora.org>
Message-ID: <b1e7949d-71ff-7a47-ea3b-04ef6579b9df@codeaurora.org>
Date:   Fri, 20 Nov 2020 17:06:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201117004052.14758-2-paulmck@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/17/2020 6:10 AM, paulmck@kernel.org wrote:
> From: "Paul E. McKenney" <paulmck@kernel.org>
> 
> There is a need for a polling interface for SRCU grace periods.
> This polling needs to initiate an SRCU grace period without
> having to queue (and manage) a callback.  This commit therefore
> splits the Tiny SRCU call_srcu() function into callback-queuing and
> start-grace-period portions, with the latter in a new function named
> srcu_gp_start_if_needed().
> 
> Link: https://lore.kernel.org/rcu/20201112201547.GF3365678@moria.home.lan/
> Reported-by: Kent Overstreet <kent.overstreet@gmail.com>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---

Reviewed-by: Neeraj Upadhyay <neeraju@codeaurora.org>


Thanks
Neeraj

>   kernel/rcu/srcutiny.c | 17 +++++++++++------
>   1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
> index 5598cf6..3bac1db 100644
> --- a/kernel/rcu/srcutiny.c
> +++ b/kernel/rcu/srcutiny.c
> @@ -152,6 +152,16 @@ void srcu_drive_gp(struct work_struct *wp)
>   }
>   EXPORT_SYMBOL_GPL(srcu_drive_gp);
>   
> +static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> +{
> +	if (!READ_ONCE(ssp->srcu_gp_running)) {
> +		if (likely(srcu_init_done))
> +			schedule_work(&ssp->srcu_work);
> +		else if (list_empty(&ssp->srcu_work.entry))
> +			list_add(&ssp->srcu_work.entry, &srcu_boot_list);
> +	}
> +}
> +
>   /*
>    * Enqueue an SRCU callback on the specified srcu_struct structure,
>    * initiating grace-period processing if it is not already running.
> @@ -167,12 +177,7 @@ void call_srcu(struct srcu_struct *ssp, struct rcu_head *rhp,
>   	*ssp->srcu_cb_tail = rhp;
>   	ssp->srcu_cb_tail = &rhp->next;
>   	local_irq_restore(flags);
> -	if (!READ_ONCE(ssp->srcu_gp_running)) {
> -		if (likely(srcu_init_done))
> -			schedule_work(&ssp->srcu_work);
> -		else if (list_empty(&ssp->srcu_work.entry))
> -			list_add(&ssp->srcu_work.entry, &srcu_boot_list);
> -	}
> +	srcu_gp_start_if_needed(ssp);
>   }
>   EXPORT_SYMBOL_GPL(call_srcu);
>   
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of the Code Aurora Forum, hosted by The Linux Foundation