Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbWHXVPH (ORCPT ); Thu, 24 Aug 2006 17:15:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751702AbWHXVPG (ORCPT ); Thu, 24 Aug 2006 17:15:06 -0400 Received: from alpha.polcom.net ([83.143.162.52]:37868 "EHLO alpha.polcom.net") by vger.kernel.org with ESMTP id S1751619AbWHXVPD (ORCPT ); Thu, 24 Aug 2006 17:15:03 -0400 Date: Thu, 24 Aug 2006 23:14:57 +0200 (CEST) From: Grzegorz Kulewski To: Oleg Verych Cc: linux-kernel@vger.kernel.org, pingved@gmail.com Subject: Re: [PATCH] boot: small change of halt method In-Reply-To: <44EE2228.5020807@flower.upol.cz> Message-ID: References: <20060824184447.GA3346@windows95> <44EDF923.4030607@zytor.com> <44EE2228.5020807@flower.upol.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 35 On Fri, 25 Aug 2006, Oleg Verych wrote: > H. Peter Anvin wrote: >> Andrew Brukhov wrote: >> >> > I'm new here. >> > After reading boot code i'm immidiatly change this string: > ... >> > + * Small fix of halt method Andrew Brukhov, Aug. 2006 >> > */ >> > > > >> >> while (1) >> asm volatile("hlt"); >> >> ... since HLT only pauses until interrupt. >> > Why not to have a reboot here? > Testing and getting such errors on my laptop, it needs a power cycle. And what if hlt is buggy? I have at least one pIII tualatin based server that has some strange mainboard problem and will work only if nohlt is passed to the kernel. Thanks, Grzegorz Kulewski - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/