Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1363998pxb;
        Fri, 20 Nov 2020 07:48:24 -0800 (PST)
X-Google-Smtp-Source: ABdhPJx85fogq0mK76bin89atXl8bjFtPWMEqrLqMQOU3J0ve/9gliTaoydiwIO9sRih/VkTzS6E
X-Received: by 2002:a17:906:960c:: with SMTP id s12mr205428ejx.353.1605887303818;
        Fri, 20 Nov 2020 07:48:23 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605887303; cv=none;
        d=google.com; s=arc-20160816;
        b=xHN8LtuHNgxNuobec8BSl2am+ns4A/c9e5X41HKTWyzVT7yrNUyaGCzX0EYDqqi420
         ncMVW1Ejz5cG0qgznuoO17QCQS0HYc2KfIb/tGtojURvP++f3S6Kruw3XzqFeo0HgzlB
         FQaPGD/Vs7hNRVWEsTriEuV65zrhjs6GKQKIrbXy+RYKWzaetuzOnHPVxL1Fk/4Y1ivU
         tydFW7HsN6ytRDME2e8mf7T91/OrocTUCMj0bvoPneF3Wz7EZ1cDx1lbZjPRSXURRoWv
         6RYcen+d2UCKS927p1EL0udOxMHQ8hTj8BzVBvxk5VxnkO8+rpBGkldAOascsGADLcFr
         hxEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=1xNekgvCuQLRczyChi/ec7auLvegvkMFfoxSiKQPWjY=;
        b=APpMcUt8hJKbpb7Bjo0LKOCxCNoYjCsqoZH1BNcJZjdWTxp7Cw6dzW6JkxscxXn+Ds
         ti5UD2Np01ch7h3Qf9AkdJT55Jta8cjpJVpyq8++18HUEyR9vUBFXm3vPaSpqD62tNOi
         BPl+eLdr71bWyzwFN445jqycXSlNYn5a0NrqmoOOEuxHdqm1vfrh4xDMwz/3zxtz93cb
         FV57PflJc+9oIN1rxBrADZUubs1TNzRXTK6OdahMOMHxqq5DA+2q+Z9uVD1gZXu4fbHr
         wEwgIL/sx/upxwnrNiosKbv0g3k6vEXSPQtSi+pZtKHcZ/nRKpL2dN3txfCczaOODOQz
         rCsw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=BEAc9G8R;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a1si1816228eje.21.2020.11.20.07.48.00;
        Fri, 20 Nov 2020 07:48:23 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=BEAc9G8R;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729858AbgKTPoq (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Fri, 20 Nov 2020 10:44:46 -0500
Received: from mail.kernel.org ([198.145.29.99]:41090 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728579AbgKTPoq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Nov 2020 10:44:46 -0500
Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id EB11A22252;
        Fri, 20 Nov 2020 15:44:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605887085;
        bh=sp7MQRrcnzIk7JiBCxm/j4/NwDTlMMp0aYn+xU0l/Xg=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=BEAc9G8RizVryxLp3t3FRWijmk5sCJ9ExdtpWVnnLsdAhtWFZxqWOgqGXohLF+/TE
         1oBpKnsbIP3fOz7Ncnv0gmOye/qilK1k7bOtHttYRZlM5NatyAcYJ+6ydYhci4IiHh
         hbRtzyVaI83z9Va1FEu9cnZlgA08e3mqmQXsF7c0=
Date:   Fri, 20 Nov 2020 07:44:44 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Huazhong Tan <tanhuazhong@huawei.com>
Cc:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <andrew@lunn.ch>, <mkubecek@suse.cz>
Subject: Re: [RFC V2 net-next 1/2] ethtool: add support for controling the
 type of adaptive coalescing
Message-ID: <20201120074444.741b9aaa@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <1605853479-4483-2-git-send-email-tanhuazhong@huawei.com>
References: <1605853479-4483-1-git-send-email-tanhuazhong@huawei.com>
        <1605853479-4483-2-git-send-email-tanhuazhong@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 20 Nov 2020 14:24:38 +0800 Huazhong Tan wrote:
> +  ``ETHTOOL_A_COALESCE_USE_DIM``               bool    using DIM adaptive

Sorry, I didn't get into the discussion on v1 in time.

I'd prefer this to be an enum (u8 or u32) the values can already be:
 - device (HW / FW)
 - driver specific
 - DIM