Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201120015913.1375667-1-jannh@google.com> <20201120153559.GA4119@sequoia>
In-Reply-To: <20201120153559.GA4119@sequoia>
From:   Jann Horn <jannh@google.com>
Date:   Fri, 20 Nov 2020 16:45:46 +0100
Message-ID: <CAG48ez22JooyfTbPkhhfU15Oo3vcRr-bc1d3SQV1aGFaQuwVfA@mail.gmail.com>
Subject: Re: [PATCH] seccomp: Remove bogus __user annotations
To:     Tyler Hicks <code@tyhicks.com>
Cc:     Kees Cook <keescook@chromium.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Will Drewry <wad@chromium.org>,
        kernel list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 20, 2020 at 4:36 PM Tyler Hicks <code@tyhicks.com> wrote:
> Hey Jann - Thanks for cleaning this up!
>
> On 2020-11-20 02:59:13, Jann Horn wrote:
> > Buffers that are passed to read_actions_logged() and write_actions_logged()
> > are in kernel memory; the sysctl core takes care of copying from/to
> > userspace.
> >
> > Fixes: 0ddec0fc8900 ("seccomp: Sysctl to configure actions that are allowed to be logged")
>
> After tracing back through the code, I was struggling to understand why
> I thought the __user annotation was needed back then. It turns out that
> __user was correct when I wrote 0ddec0fc8900 and that the Fixes tag
> should be changed to this:
>
>  Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
>
> If you agree, please adjust and resubmit with:
>
>  Reviewed-by: Tyler Hicks <code@tyhicks.com>
>
> Thank you!

Aaaah, that makes sense. Thanks, will do.