Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1389188pxb; Fri, 20 Nov 2020 08:19:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqPex9vgIBjImTrEK4D6KUulXbWY/Y/D2PWPIvqZ53UdVEGum/27j2gXNZ6PaBEOK6oTRB X-Received: by 2002:a50:8e0e:: with SMTP id 14mr24745904edw.171.1605889195852; Fri, 20 Nov 2020 08:19:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605889195; cv=none; d=google.com; s=arc-20160816; b=Oj1xb4mW/+XB41ltlehvIEutTqYxoxKzC3rMQFFQk2uSzaW67yvmqFETMepZDbzvEi 0UgQts4fjrKdNXhQpaF/dJqapMzZ9TYW+t0BBKoTr3Sr80R3xIdpIcJSIBY6qrrFJnCv 6/9aLABXekLiMXJJx6TF/vsaSb6FSzFYXLFuDXfHZtHi+mlOTnIGH4saBCbcZ5a1Xb6e jqHoThe2KaSJcP9L03qUZN7/s0cq7OGfISVvOC05fYokkTkvtSmoIX8sG1G+mvnsnQMv jl+lNob62n6z2vOBS5t9xUIDc7PLaRKnwTiVTxvyC732OdoYSXT3dxaskEKODh52hBtH lVxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=73ycrjxgjw9bhllebs7sZPsrs1SMmf1dIyhpDIKC6ds=; b=GmFA9uyUAJTY/oyPscO/9FsCDeL5oqnmBJvP9plNZJKQvRVhLH5F03iO/y5NmuptSd Jts9PndP39FlL7yxCBu2V9JCMQb4eVApzJbOngqN0aBXZIyVi2B6MoJ5tMl3uaYe/Lig VcAnL6LWuPQWypGe+DCu7fcq/WKVnDFrvQpiCzxEcA6WIT7k75loRE00KtdtvQ39h2OP e2sdysS+YHn7KfvD9hkXZFi8ZCYiHIPWz1aFG9AECboOQwPS4C6AvMKo44+TrHH4VJoU Fm5TrhUZpiT64lSGlvmQmIMNfCdA8xdr7ryyewcTy/KObimr2U3SEVail31UwnASmIC1 KKmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si1206407edy.218.2020.11.20.08.19.30; Fri, 20 Nov 2020 08:19:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgKTQPm (ORCPT + 99 others); Fri, 20 Nov 2020 11:15:42 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:63361 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728254AbgKTQPl (ORCPT ); Fri, 20 Nov 2020 11:15:41 -0500 X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 690A640044; Fri, 20 Nov 2020 16:15:38 +0000 (UTC) From: Jacopo Mondi To: kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org Cc: Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: rdacm20: Enable GPIO1 explicitly Date: Fri, 20 Nov 2020 17:15:29 +0100 Message-Id: <20201120161529.236447-3-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201120161529.236447-1-jacopo+renesas@jmondi.org> References: <20201120161529.236447-1-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MAX9271 GPIO1 line that controls the sensor reset is by default enabled after a serializer chip reset. As rdacm20 does not go through an explicit serializer reset, make sure GPIO1 is enabled to make the camera module driver more robust. Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver") Signed-off-by: Jacopo Mondi --- drivers/media/i2c/rdacm20.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c index 1ed928c4ca70..16bcb764b0e0 100644 --- a/drivers/media/i2c/rdacm20.c +++ b/drivers/media/i2c/rdacm20.c @@ -487,9 +487,18 @@ static int rdacm20_initialize(struct rdacm20_device *dev) * Reset the sensor by cycling the OV10635 reset signal connected to the * MAX9271 GPIO1 and verify communication with the OV10635. */ - max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); + ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; + + ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; usleep_range(10000, 15000); - max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); + + ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); + if (ret) + return ret; usleep_range(10000, 15000); again: -- 2.29.1