Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 20 Nov 2020 16:56:34 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Shengjiu Wang <shengjiu.wang@nxp.com>
Subject: Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id
 table
Message-ID: <20201120165202.GG6751@sirena.org.uk>
References: <20201120161653.445521-1-krzk@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="D6z0c4W1rkZNF4Vu"
Content-Disposition: inline
In-Reply-To: <20201120161653.445521-1-krzk@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--D6z0c4W1rkZNF4Vu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 20, 2020 at 05:16:15PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).  This fixes
> compile warning (!CONFIG_OF on x86_64):

It would be better to fix these by annotating the table as potentially
unused, if nothing else it means if someone wants to add ACPI support
(or it just works on their ACPI system with the plain old I2C ID) then
they don't need to revert this change.

--D6z0c4W1rkZNF4Vu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+39UEACgkQJNaLcl1U
h9CgmAf/TTilda96a36q485f2SyA+IVRXAggLG/0IGEmSeyFkPP8BmZuQnO2upBd
nym7EJHvUPEUn+Fb+Y9CaHG773ncymC/+L695gqlaf4LZNph2FmatHUhQE001ULh
07CC9JJ1CMMRQblKn6wKrLN6D8MvdLXAMI+NOyk+mINvH418nEXRnLZSmhvK2poa
w+gU7sM6xBNc8dcrOXSUB4GeWRSk5e5o3zGIB3CkPQaomoEH81bINbKw1wGbyHuC
r7xRgGrCr2UV2SMQHz74EXvCx9dsGwc7G6nHaN6AqLeyUkHBXojKet8kJsOxwFui
c1rPK+vfugjrmYf7IsLKPizFuqozqA==
=/Bw1
-----END PGP SIGNATURE-----

--D6z0c4W1rkZNF4Vu--