Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1427804pxb; Fri, 20 Nov 2020 09:11:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEra4Jn/YtqBm5Vm8xfTNtB+AV6VsYxVnye6lTOk3Ovn3shDktZPINtET70O7LwHLUl6nN X-Received: by 2002:aa7:d351:: with SMTP id m17mr37104197edr.215.1605892312845; Fri, 20 Nov 2020 09:11:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605892312; cv=none; d=google.com; s=arc-20160816; b=IKarujsRx9XGW44y2kp1rTcjBdISBenQ2UU3eYP/Y8FpSfvxK73rbyQz2Nye/aTXIb yH7+7JPn3B6ukehVLZQhLUyuvLW9x0y32umZsEg5aFGkSOUPmXVX2LvFI9N+2GwWOQvr e4SBryPntnWdpgjo2sJG3fOKGAgqGRl65OjNvRAhGvfrjRTj9xPWtODpSoBb9Pz7Fpd6 EMyPX24Jsdr7wcR1t9WMYMkZOIZ3fGJck64IDoXU6a2K1rCT5hNS5wzKsvA+CIiawlpb t3smN+jwgH3o4imh3KficwS0H4k8RgfT5As9GkCzNG9TDc9pdPgMS5pGkVsY2FHZqrL7 Dy0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wa4smNXKYOZ9uqqE52pWfpVJyl2VLtE6Z6JROqvlIwE=; b=Rgf1Fg2syKZ/GQoz+FG6g2LNF6qm0VKLfDIDsMt1WFEFBu+3U95acoQp57YbCGDH1k EBj7HnsEgeVRh9Nrtz0jPHtSs9QL6AYSMVbpSFbQP7cyCNeoWn4+1cnzpG1xHzO2oC1I OrIIzYcpyvZKMBFErDA+C4G4948s3mLezmlXTBTqugo2y7bEvUCpFIwVWCWtHQ2xkB3g VSPeJovrCUGoiDtkiKwl/cSupVz5NCoVI01cSkyRG81pJTHR/IL85rux8J6p0ZSqs6Mn wXSrSp2VipcyR0Q5TZdg9H3vERsbpo2XqVjEjkeSoPTLTMtBu1shKirpSbinTZfl4swF KcUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si1923597ejg.330.2020.11.20.09.11.25; Fri, 20 Nov 2020 09:11:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730309AbgKTRHW (ORCPT + 99 others); Fri, 20 Nov 2020 12:07:22 -0500 Received: from foss.arm.com ([217.140.110.172]:52580 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729976AbgKTRHV (ORCPT ); Fri, 20 Nov 2020 12:07:21 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CA5B1042; Fri, 20 Nov 2020 09:07:21 -0800 (PST) Received: from red-moon.arm.com (unknown [10.57.59.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68C893F70D; Fri, 20 Nov 2020 09:07:18 -0800 (PST) From: Lorenzo Pieralisi To: linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Jim Quinlan Cc: Lorenzo Pieralisi , Florian Fainelli , Nicolas Saenz Julienne , open list , Andrew Murray , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Rob Herring , Jeremy Linton Subject: Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization Date: Fri, 20 Nov 2020 17:07:12 +0000 Message-Id: <160589201520.1295.14447752492499400941.b4-ty@arm.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20201102205712.23332-1-james.quinlan@broadcom.com> References: <20201102205712.23332-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2020 15:57:12 -0500, Jim Quinlan wrote: > The variable 'tmp' is used multiple times in the brcm_pcie_setup() > function. One such usage did not initialize 'tmp' to the current value of > the target register. By luck the mistake does not currently affect > behavior; regardless 'tmp' is now initialized properly. Applied to pci/brcmstb, thanks! [1/1] PCI: brcmstb: Initialize "tmp" before use https://git.kernel.org/lpieralisi/pci/c/ddaff0af65 Thanks, Lorenzo