Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1434126pxb; Fri, 20 Nov 2020 09:20:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJySZfJld4AP4Bp0WTeNAxsERqv+ZDIUL9bj2/0sGGs/vQkFdySEup7DVUqVXZNjEGzSaVCH X-Received: by 2002:aa7:da01:: with SMTP id r1mr37392045eds.45.1605892822367; Fri, 20 Nov 2020 09:20:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605892822; cv=none; d=google.com; s=arc-20160816; b=jZCZygcbwEUfilUv1XvfIwKtVwSA6GavEKv29kosKNY0batbQF9jFIme1EUvuRIJka bCN8rPIttXQ9TFXoOh/RQPKnqcX21fOoPF379DOmep51xJEysXDBNexkoVLTlbTtLXGN 4h1jjz6gyOrUGDUh2VmpmnE/H2WoEAAfMtrZd8YfKrIKYKCrCNwaqvXvagbl1S/XnP/E K5rGIcDmuwc06FeuT+uNeg9PJ2gwAQ7SM559MULPbA8KuwTfs7H5kw88Hhvwyf7cRuaT 9Q0Y5bbX3DnvbyElNRAGA9wjy6WMxZk9p6dJVi645ImjKgu3s3pRKt6o5BmC2zBYsHzs y3RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=uy+51xeLLzq1vXGE7LGJb4vNbh6FZc0ca+/BpSaUnJ4=; b=K1HLFrcda3qzNZPeAnfM29EVrOM8Jf1AFMTSD6E9Rse/1iZD/f4lAWsEqzc0mxz5Li /R1+epWwVQH6vUa6Q2ioyqAf874D1Ud66ZyF6DSrOevn/JMoUAQsQ5rUPksTj/bMAmxb dxx1dnol4KwVY9SyqPyYbf5XxqhpqJTbVF/J3EVf34pcqApRG6Ac1uUR8x7zVbD0K48X 3x+UqRJyH22pEprR+rMXweEDEV5/vzwemRGCkdxU3LV3fWOFXlMZnD8pHZJ2/XpPmVgt fL0mtrnkeQFkxqGwQlyBnSbHSSQRWRCamOku9gu7XAVoJkjfl78HdQXU3AekoibKxSg+ 7vdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzOH+qDo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc4si1986188ejb.200.2020.11.20.09.19.59; Fri, 20 Nov 2020 09:20:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzOH+qDo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727370AbgKTRSK (ORCPT + 99 others); Fri, 20 Nov 2020 12:18:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:58142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbgKTRSK (ORCPT ); Fri, 20 Nov 2020 12:18:10 -0500 Received: from localhost (cpc102334-sgyl38-2-0-cust884.18-2.cable.virginm.net [92.233.91.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20E1822252; Fri, 20 Nov 2020 17:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605892689; bh=uy+51xeLLzq1vXGE7LGJb4vNbh6FZc0ca+/BpSaUnJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TzOH+qDooBkM+qvyFtDXceRJ1uL8IxPw/J70qTrL7zQrK29OIKZBH7oM6az5lypL7 jd3ZlMeuno8YVqrLgLffY6Ui4owRy524YZhVa7lW1GJJOgrvMhBGU6mrjy/vlcieZo iUem9dXye8RjtpAWFLrCcSs8Wn556NVCn8dNnurE= Date: Fri, 20 Nov 2020 17:17:48 +0000 From: Mark Brown To: Serge Semin Cc: Serge Semin , Alexey Malahov , Ramil Zaripov , Pavel Parkhomenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] spi: Take the SPI IO-mutex in the spi_setup() method Message-ID: <20201120171629.GH6751@sirena.org.uk> References: <20201117094517.5654-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NqNl6FRZtoRUn5bW" Content-Disposition: inline In-Reply-To: <20201117094517.5654-1-Sergey.Semin@baikalelectronics.ru> X-Cookie: Have at you! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NqNl6FRZtoRUn5bW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 17, 2020 at 12:45:17PM +0300, Serge Semin wrote: > Of course I could have provided a fix affecting the DW APB SSI driver > only, for instance, by creating a mutual exclusive access to the set_cs > callback and setting/clearing only the bit responsible for the > corresponding chip-select. But after a short research I've discovered that I think the driver needs a fix anyway for the case where there's a mix of devices with standard and inverted chip selects, it assumes they all have the same polarity AFAICT. --NqNl6FRZtoRUn5bW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+3+jsACgkQJNaLcl1U h9BwLgf+Lis0gdGmaCp6BXLmrpL/5yxKSuQ4g3xHQigJuLJyrPf4GoaQSMv34u1z rGowoRkVYkjpfeqtFAG9ns/ozKKdVJkgcycEWl/KZI6Gia7COUdlNHHaiJaSeDQk qqTbB4ZoDVrSRqd7tE6hAurM18DxwY5fFYEvN39XOZEakqMeqgQ8x9+iwe59VPsw bwJV0FzAIPnCx/AbdIaU+FA6LTJpSJp1dWzzVW+tvxXkeEpBgVAHMOdSc8LwnkiS szD4KAaR3VRvQ3rjunaXQlJPVctdIhPnknVEFnZKDwaQIBlmoyvy0By1CZ3+woMZ Ogq5RaosPg+EOYnY3K0VFUFShzSd4w== =YaE4 -----END PGP SIGNATURE----- --NqNl6FRZtoRUn5bW--