Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1444437pxb; Fri, 20 Nov 2020 09:35:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQatsOIKP1SSCwo/dbNG+6o0QiYs/coZG9vlA/Cg5qFTJnEhDxHXwO+YPJbBa++ZYyS+ni X-Received: by 2002:a05:6402:2363:: with SMTP id a3mr11100406eda.388.1605893715796; Fri, 20 Nov 2020 09:35:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605893715; cv=none; d=google.com; s=arc-20160816; b=nHAKQe0I/s9EHa/5yw3W0yPqY4IWsrIS3W64KoZoHvkvKdO3uonwokjXUIHWfCTp/I bDMQsZrroZHU21eIXHsBtdb9KrRqL+mOx2urd7MZ67Vl7C8SoagmfNMVv2Wz0+NPkR2c ovpNPu/eHVGcJUibThFzwGcdwvLhzQXga24J7CMdMEN1blJrV5yKGUS9qapnlIwhWc+V Qe2pFAF98wkCKzzVExmzTxWUanwN8z2DKn+j2NswqqliZWn7ZrZtRCWn8p3Xd8Cc5BBy pn0oNnm6ugNwpx3rntpchMBOqGb361stvJTSCHAbKTsgXPIewF2T57cFALCjZhdNGTI9 BpAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HZrEZZXLfDY6ZBG3BwoqOBdMQ5Sk++T8MhO/n+cHc/0=; b=1KYQfgRY/6KjuybkefnSewC+cuDvqkNeXKeHEhJRlCiwHb3p/NbdbR3PirGU+GDgbP dzeWgZ7DYKDTLQ4VOSiwiw93ciiVr78GphE5ebQzDABwYoEvr30ANqZnEjwiCYC7qOCq 3wzkGGCQAGm7C8jUEEkurEyUtMbd2Aee4XS1KHqr4GwDAmOIQmm3zNwdeuSMuE4wn07N 5+nJ8cbhaS63Kd6D4TDHyJar8dK74IeToEvwGxeTuRFIoKC7/XpN7NICk8UE/h0IlZyu RS7qsB9jwInFjcb44hX56dRcj1ARb0uhFdsGKgw/BR79lC0LBmQjbI0hEITNW3NXByF1 JVyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=CaDpxvvd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx21si1572250ejb.469.2020.11.20.09.34.51; Fri, 20 Nov 2020 09:35:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=CaDpxvvd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728768AbgKTRcZ (ORCPT + 99 others); Fri, 20 Nov 2020 12:32:25 -0500 Received: from mail.skyhub.de ([5.9.137.197]:53824 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbgKTRcY (ORCPT ); Fri, 20 Nov 2020 12:32:24 -0500 Received: from zn.tnic (p200300ec2f11ba0074b4ba83d21d5a9c.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:ba00:74b4:ba83:d21d:5a9c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 745471EC047E; Fri, 20 Nov 2020 18:32:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1605893543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=HZrEZZXLfDY6ZBG3BwoqOBdMQ5Sk++T8MhO/n+cHc/0=; b=CaDpxvvdbtKE4hJTkfCdW4efawbiLUdh5aW5+vFj+22Kb9RrAdx48LAx6pSAnvWM4DHtRn 1L87kHuoF1nrimVsAm116Y+uLf8zBzmIsiY/gnBeq2Drk0KCyKOY+IyhtWwwTv3zSYw41H h+Jsey14d0vM43GXXdsf0FLByaIGiXc= Date: Fri, 20 Nov 2020 18:32:17 +0100 From: Borislav Petkov To: Gabriele Paoloni Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech Subject: Re: [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce_end() fails Message-ID: <20201120173217.GE712@zn.tnic> References: <20201118151552.1412-1-gabriele.paoloni@intel.com> <20201118151552.1412-2-gabriele.paoloni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201118151552.1412-2-gabriele.paoloni@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2020 at 03:15:49PM +0000, Gabriele Paoloni wrote: > Currently if mce_end() fails no_way_out is set equal to worst. > worst is the worst severirty that was found in the MCA banks > associated to the current CPU; however at this point no_way_out > could be already set by mca_start() by looking at all severities > of all CPUs that entered the MCE handler. > if mce_end() fails we first check if no_way_out is already set and > if so we stick to it, otherwise we use the local worst value > > Signed-off-by: Gabriele Paoloni > Reviewed-by: Tony Luck Also, this very likely wants Cc: stable, I'd say, considering the severity. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette