Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1445531pxb; Fri, 20 Nov 2020 09:36:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMLo6fod28nsf+cBb2aFKH1MCBVwH8CbY63Uik2r+qxkUXorj9e2tmqKPc1yqIYOTVCsck X-Received: by 2002:a17:906:d8a8:: with SMTP id qc8mr33506235ejb.149.1605893808552; Fri, 20 Nov 2020 09:36:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605893808; cv=none; d=google.com; s=arc-20160816; b=KUz3x34RtMFYORdc9GV4Fm3pqmCXD/ddgKg7kc24fdv6ZztiULTCOeZtvMqS1EUMuA VLd2hxmxQQRqw/ixYRsAP2fede5g6RV6i76N67bNLwVF3s9zQnk+gU6OGiqcDaaY5DPf vG4PelYLKYZoi/UvjNMe8ZB2h/KhxmNEa/e9I7MGwt+Dy+ku2yyWivb8DriFuN3JkBX5 7qF93JKe31rWqMZ1PBcwNU6S9/ksqT89URvBFRtJgfgNVPVjroigETaSNEeJ/FpqlRpw LCsCGByxN9c/yshGwzh/HiPWCBVUKLLc+SVa+OJfntJy8d/t/AhRidXhAaH+6hWxdTB7 7ziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7F9wI7CLFPCOZwx9Gq9w3Uf3TTwIQ/yoyoiY54mFMwc=; b=VmNk60CHA9aXf8gXheaTVc5PFg1jKcRAEWe7o2TdlMm+x+8kimEAyccQjfnaoQjgIo ibfZxPSiZTGtVHbQGjOcokF6zkAwYLdltAky0v7JH98DYvjS7QKpNvb/bKuxpSyAZcPx p0o7doKhDOf/IFAsOL/0S5woUb02lLah3nzFrZhO4Mt8pdKDxe0jM2HJDWBaQtNwm4GX CIOigzAvioYGIQCrpi0oP9cdRx3uuuATGA6Spefo/8Q8ghWBv/uTdc5lz2Y8rPaOLL4E nE+CjXHNej8iHsmAHUqkL5B0ifKvlLSo3zPt4AnfZJ+c1lxCFBrng0xUyIJx9MLCFxfw Xtew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=eoSRNg9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si2315829edi.111.2020.11.20.09.36.23; Fri, 20 Nov 2020 09:36:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=eoSRNg9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbgKTRdp (ORCPT + 99 others); Fri, 20 Nov 2020 12:33:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728488AbgKTRdp (ORCPT ); Fri, 20 Nov 2020 12:33:45 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16912C0613CF; Fri, 20 Nov 2020 09:33:45 -0800 (PST) Received: from zn.tnic (p200300ec2f11ba0074b4ba83d21d5a9c.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:ba00:74b4:ba83:d21d:5a9c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AAC031EC047E; Fri, 20 Nov 2020 18:33:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1605893623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=7F9wI7CLFPCOZwx9Gq9w3Uf3TTwIQ/yoyoiY54mFMwc=; b=eoSRNg9f849ehHv3xGJYKPUwgqQzvgHmW7lKHsCIFqrfDmNeUkmPVAFCScVoXap8S9wcHN MZXugY1CfEtoa20sZ9IsRmILPzCdAoaqry1lgq5ZZAeC4rVUsXXFkcTCncO/V034l+TGaC 8GfrS7IGDONOtL5YFMq22/w5zjXjg4c= Date: Fri, 20 Nov 2020 18:33:42 +0100 From: Borislav Petkov To: "Paoloni, Gabriele" Cc: "Luck, Tony" , "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "hpa@zytor.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-safety@lists.elisa.tech" Subject: Re: [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce_end() fails Message-ID: <20201120173342.GF712@zn.tnic> References: <20201118151552.1412-1-gabriele.paoloni@intel.com> <20201118151552.1412-2-gabriele.paoloni@intel.com> <20201120170737.GD712@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 05:31:32PM +0000, Paoloni, Gabriele wrote: > I mean that on this CPU thread at this point mce_start() already cached > global_nwo and hence could accumulate fatal severities of other CPUs. > > Now here if mce_end() fails we only consider the local 'worst' severity > and we overwrite those already cached. Yap, we're on the same page. :) > If ok I will fix the grammar and rewrite this code in v2. Sure, lemme go through the rest first. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette