Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 20 Nov 2020 18:46:16 +0100
From:   Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
To:     Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Richard Palethorpe <rpalethorpe@suse.com>,
        LTP List <ltp@lists.linux.it>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from
 charging root
Message-ID: <20201120174616.GA94676@blackbook>
References: <20201016145308.GA312010@cmpxchg.org>
 <20201016171502.GA102311@blackbook>
 <20201019222845.GA64774@carbon.dhcp.thefacebook.com>
 <20201020162714.GC46039@blackbook>
 <20201020170717.GA153102@carbon.DHCP.thefacebook.com>
 <20201020181822.GA397401@cmpxchg.org>
 <20201021193322.GA300658@carbon.dhcp.thefacebook.com>
 <20201023163053.GB535375@cmpxchg.org>
 <20201110012758.GA2612097@carbon.dhcp.thefacebook.com>
 <CALvZod7GrYayHjYsqtF2AfcvkbTHCyWQJW4oXoO3fSGJeotDpQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N"
Content-Disposition: inline
In-Reply-To: <CALvZod7GrYayHjYsqtF2AfcvkbTHCyWQJW4oXoO3fSGJeotDpQ@mail.gmail.com>
Precedence: bulk


--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi.

On Tue, Nov 10, 2020 at 07:11:28AM -0800, Shakeel Butt <shakeelb@google.com> wrote:
> > The problem is that cgroup_subsys_on_dfl(memory_cgrp_subsys)'s return value
> > can change at any particular moment.
The switch can happen only when singular (i.e. root-only) hierarchy
exists. (Or it could if rebind_subsystems() waited until all memcgs are
completely free'd.)

> Since the commit 0158115f702b0 ("memcg, kmem: deprecate
> kmem.limit_in_bytes"), we are in the process of deprecating the limit
> on kmem. If we decide that now is the time to deprecate it, we can
> convert the kmem page counter to a memcg stat, update it for both v1
> and v2 and serve v1's kmem.usage_in_bytes from that memcg stat.
So with the single memcg, it may be possible to reconstruct the
necessary counters in both directions using the statistics (or some
complementarity, without fine grained counters removal).

I didn't check all the charging/uncharging places, these are just my 2
cents to the issue.

Michal

--fUYQa+Pmc3FrFX/N
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAl+4AOMACgkQia1+riC5
qShDDA//VKPWDCNm70dyHIeZkqaD/EqDTDbcSYSs+4zTlOnYg4Mf1oahYAuZJR9i
5UwJwvyNu7zDQJJb2wGPBfrhWnc8LMJwKuedjWYUhZnm1mifdL1/4eomL/B6UdhI
qjaWI5C+NCc/Yvu4tjTDvGwJvQsRNlEqHNvlcU8Lq6xhBO0+eFSm6LClcbLJDpC2
lMNHkcIlyA7la+dDkOJGQ798tbZUAeIaBaj6v/cmWP4By9QZFLctIIFuwZVE7zUY
irzTx2B2zeVXpQDdkriRG/+WtQRmAYvhcgHuhCORDJd2Ue7gYD8ShD+Z9zTdbkHH
OkdvZ7vQ2B3Rf/uoiOU+Q4Mk9qmlpLlYWHlTvvQaOcFSvx37FDWVsZRE2vTjI8PH
8/pji3Qd27cGLzqlsWbNFPGcz5mouoLMV5M5FfpPL5tzTc+CrONmgRv5SOW9ID8e
EChWvp6sVrU2hiSZ7EODR3c1OsntR8GxVZGeJJL9YJO6H6FPW5m88oGTpXl07jUh
bYlZPdmD4F3ar8kP0acD5wDqQhRaz2Ryj+37uV+IdmVS4br26bUf/jgGQ9Vj/4Pa
xypvUHRP6DRxfytu20OEbCa8e9/kI27MAjRVOFX6pUrfAu5tf0zjlvLFBFjBlaTn
2Mr2wJn3VO8bOToSzu/JLlIqGN2F1oya9KQqmZSRKUGypR3qQv4=
=tHCs
-----END PGP SIGNATURE-----

--fUYQa+Pmc3FrFX/N--