Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1476869pxb; Fri, 20 Nov 2020 10:22:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBMt2fxbtMz9iOdmBJZNnnfnT5+5/0lS5RwUe/TTFvBPRpy+MgVSsqxdDUAUQrnt8nEsal X-Received: by 2002:a17:906:e0d2:: with SMTP id gl18mr12824345ejb.412.1605896536592; Fri, 20 Nov 2020 10:22:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605896536; cv=none; d=google.com; s=arc-20160816; b=RN+7o3Anq2O+6ixlw8u3ZZwvONPJBYl5jWxxq1S/mIzqGa2cnlLUVm4BGCHPC1OW1e djyCAn8CH652r07hg/kYLKkTqwYvyazaCPvWYsojzm03jW/lBZ/VIfTpd4p0vyJahQPq 4vRnKRsCeIqQOe/pQ4L0cmm1ucV1PUI+nP571bh2V0ofqsslq/bj4U43tqga2U3Gy1Xk eFVYhTt2jJZF2xqQewmVrOXJIdG4J91EGKVlfFxKF7XLRItgaZ8qp1daOWOTge4EyJ0l u/eJphyvM0s9LEeBuJcpkq89nGM+uPPx/pOuuEdodY4Id+S7Sr7e9j/LILknpGYZxLwJ erZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=gY6MSqQslll6gC/MCsxlJf565gu8viMVsPrKYZjkYHc=; b=IGS9xcEcGhLnfQdTBg54QBjjoArUvntvie06pJKdVu7j1coANWs5eUpH3tWB4z9P8q D358ttUXkigQmWIhxjbtHfFV4Nzw8k6XclXSM7o/RRVkhTczAZ/2lvpDjFOpUf4i14mt BCWjMM/94ud5IYuYDP1sV+lW1zCjmAFBLveY+YHR6jBl1b42j8SbUFLtVxqy0Zww3z7G VTyW4Sr5vAnoW4xzsneC4RyWr6bj/L3bUUZ5ECmkB7XCqgZTz/8JJHt2/oCHG4WdCd5I CmoI/m8fDNRG0nxGqiqjbxf7vEZBZEIUnwXqwzA5eNGIpi6M5ORC/xl6XFu2T0m3zrlQ a1+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TtD+ZG6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si2095578ejj.520.2020.11.20.10.21.53; Fri, 20 Nov 2020 10:22:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TtD+ZG6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbgKTSRj (ORCPT + 99 others); Fri, 20 Nov 2020 13:17:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbgKTSRi (ORCPT ); Fri, 20 Nov 2020 13:17:38 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EEBC0613CF; Fri, 20 Nov 2020 10:17:38 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id w14so8639232pfd.7; Fri, 20 Nov 2020 10:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gY6MSqQslll6gC/MCsxlJf565gu8viMVsPrKYZjkYHc=; b=TtD+ZG6Cp7ELJEEcBkKFDm5b8RU3ZKl6ZsGNkv8J46GilwvIrD2It0wpzMbITxwxVM euwCEg7EYUxc2J1Y0r1QwE1tQFyOIGjG9wglhGwwjgZheNavEkcCY4mKtDo+3krfmbFa Q4V95/9empdhJ4fmToN8AfUxr5dfN5pT/RIsTZdzYUfnXzIysTAd9f1rMLub/lAj0OK3 jjC8c+fk83dhEux/mo8lqGtc3AJn388QS1jKLn/zlvQsmg6aRGhpCz5ln6zTjW2AL7H5 XYY46E6QcK9/OJPznAel9M6UMFgTZatXQGLMjCFArnxQZ09svrrCfC5taaKEjXCoK/cI rF5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gY6MSqQslll6gC/MCsxlJf565gu8viMVsPrKYZjkYHc=; b=U9xm2kpQO552HEbcAIYUVFxY8QcHaM+uaIGlna2XZvpQ7xTHt4oGHbwx6WtpQp1Tni 3i3Cnee1nRllg1pEkOWz8Mu9hIuCWUVSc7AYxbL15VOTz0EK6fbaZscEQjhe0dX4mjdP n6BNQh8hsmxBJ5QYEtl4iPIDP/+BwKOYAh6eJoGubYMTQp9NCTXcBpZloSUqmsUlMGdy ctnjF10leSuIV56QMczatJRJqjyuC0xdvS9WyNm/asLwP4Wz6cdfMhfZcSPxZlZ8vnz2 wi+uZHO1CiXPUgrBBOzxopWfiudSMj4wdIPrg72yWopZIhHsHef4umLBHnXiNC7mj8Qs 3MBA== X-Gm-Message-State: AOAM533MBmyVlwrtpQR3jNm9YLRHr4l5EtL4x7fxAlaVqsl0YA5QXLA8 r96pvq32Asu/MX/kqSNY3VCOECHbpj8= X-Received: by 2002:a63:4925:: with SMTP id w37mr18598890pga.64.1605896257476; Fri, 20 Nov 2020 10:17:37 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 15sm12202532pjy.0.2020.11.20.10.17.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 10:17:36 -0800 (PST) Subject: Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error To: Christian Eggers , Andrew Lunn , Vladimir Oltean Cc: Vivien Didelot , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201119110906.25558-1-ceggers@arri.de> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <23b205eb-4a47-c0a2-0df0-8313aee30db5@gmail.com> Date: Fri, 20 Nov 2020 10:17:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201119110906.25558-1-ceggers@arri.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/20 3:09 AM, Christian Eggers wrote: > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > immediately. Shouldn't store a pointer to freed memory. > > Signed-off-by: Christian Eggers > Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX timestamping") Reviewed-by: Florian Fainelli -- Florian