Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1480897pxb; Fri, 20 Nov 2020 10:28:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdcX/UAeZRIPFumK8NqnRBLGkCTacH7U1mRzXyTaBuOcm9Ns5iARdLOG+/LtsdB8e8SwT+ X-Received: by 2002:a17:906:ece7:: with SMTP id qt7mr15355870ejb.316.1605896925072; Fri, 20 Nov 2020 10:28:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605896925; cv=none; d=google.com; s=arc-20160816; b=R0+dFYpc5qINllHlKwnfM8+L+1lOYS+O7OeRl6yMUOin99cZsL4ZNa4+e456JhYofq G3y8pIwGMCuDZ9Jkz7hxSMBUCauJmFBR0lJRfTSByjPQWv2J9a1ziqnxajvJ30a9WCSc U4ZT5bfzv/pRGzT3liKMfv1C6DX8u6FWCsruqPl/YDS3IALB09wugrcmWjQSc+IXxQ7w S6OHrVhByRuCAYA0e+4lDneNNFXJUw1xYg0uwxZhbn3q9gwuMMTZplqeN2QgickP4vAB mQjwbRdCWFlz3oED1lEIAmuwD0vT11UkcIy/Xt8xur9+xAAQTRA9pRm9pZ0Rg5PtPQYQ DJxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IOWHj3+/lfPhrIw1htKzkTXAE5Vo1YIq0IVqtSB/0L8=; b=PO8yvcznfjqFM56+okEUgziymGLFrP9I/6qPr3nLAfppZ8F4ymbVZB+JN+obedKnHo fBcpnbWldO08htYi4tymZUWVM5DTdZ+5lj2YrYuD9PCYFYzRFuhGYJyYMFSDu7sZVPwj AVkSH+nUY/VLrWg3nBxhIYevN+Bk1RgM5p9HVJOMS/iINk+cBeId2mI7er6tj3137+wK 89jQOizHZHEOUgRUtNc3ciC7eQIxK1NO0skqrcIR3iW3MZQkR2KB0V9exk2hyeRJ88GG 0wLVwSnSQ9sHM10j8p3C5OnGXcJ1kC6yn2pg9bkX8erPUccJerzpnT6c7zVTdV1jDpNp jGog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGhM8XQ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si2249483edt.203.2020.11.20.10.28.22; Fri, 20 Nov 2020 10:28:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGhM8XQ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729712AbgKTSZW (ORCPT + 99 others); Fri, 20 Nov 2020 13:25:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:46874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728698AbgKTSZW (ORCPT ); Fri, 20 Nov 2020 13:25:22 -0500 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFCD824124; Fri, 20 Nov 2020 18:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605896721; bh=pf6kfPHaE4HzxEiOc7dj5m5zf+4ABXtrZUmxTrBrs64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vGhM8XQ8zi1783KAgnAwvuVBBc93CvB158cTTQNqnhyjy+Q/EUYe806GD2IufmK33 npmPDfMra03ksYPRSPi5C/+6jncNTP7GP8vmA/igOvMEKEFVHpF0yTrnb0BepJSgdA tqd0Bsk5AjeSaxSRN+G7YbmKxbM33CGZft9cXGBY= Date: Fri, 20 Nov 2020 12:25:27 -0600 From: "Gustavo A. R. Silva" To: Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 008/141] IB/hfi1: Fix fall-through warnings for Clang Message-ID: <13cc2fe2cf8a71a778dbb3d996b07f5e5d04fd40.1605896059.git.gustavoars@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/hw/hfi1/qp.c | 1 + drivers/infiniband/hw/hfi1/tid_rdma.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/infiniband/hw/hfi1/qp.c b/drivers/infiniband/hw/hfi1/qp.c index 356518e17fa6..681bb4e918c9 100644 --- a/drivers/infiniband/hw/hfi1/qp.c +++ b/drivers/infiniband/hw/hfi1/qp.c @@ -339,6 +339,7 @@ int hfi1_setup_wqe(struct rvt_qp *qp, struct rvt_swqe *wqe, bool *call_send) return -EINVAL; if (ibp->sl_to_sc[rdma_ah_get_sl(&ah->attr)] == 0xf) return -EINVAL; + break; default: break; } diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c index 73d197e21730..92aa2a9b3b5a 100644 --- a/drivers/infiniband/hw/hfi1/tid_rdma.c +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c @@ -2826,6 +2826,7 @@ static bool handle_read_kdeth_eflags(struct hfi1_ctxtdata *rcd, default: break; } + break; default: break; } @@ -3005,6 +3006,7 @@ bool hfi1_handle_kdeth_eflags(struct hfi1_ctxtdata *rcd, default: break; } + break; default: break; } @@ -3221,6 +3223,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe) req = wqe_to_tid_req(prev); if (req->ack_seg != req->total_segs) goto interlock; + break; default: break; } @@ -3239,9 +3242,11 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe) req = wqe_to_tid_req(prev); if (req->ack_seg != req->total_segs) goto interlock; + break; default: break; } + break; default: break; } -- 2.27.0