Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1484101pxb;
        Fri, 20 Nov 2020 10:33:34 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxjH9BIilp5FZAfJXe9ms7699DGIJvoO7mgpDzs92rYl6LrqOomRWhmDS01zJ7AJaprZLBi
X-Received: by 2002:a17:906:2e55:: with SMTP id r21mr7920895eji.46.1605897214296;
        Fri, 20 Nov 2020 10:33:34 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605897214; cv=none;
        d=google.com; s=arc-20160816;
        b=mfVYQyZDA5DvTWlTKIlgHEFgT5FyZLBQO2SpsIFdIO47v0ByyisOm8El1Vo4ld2Lmu
         91ECyVugheEWrtSRAQlQ+HYmAo7kKkAcbHqnP/VPqDrrtrZ1tlWE+3IFz2AFXHFaS24i
         VW4/+JV8W1HPmyp08lbzn19qPd8o6RFGCOXBpqtijH6FxBTHc3sZoBrmcRAu+nwG+Mt/
         QFPJcV2nFFKXas8phu5HGHhQ19+CMOzrtP6idfUXBhpoFNdgk+pIex3Ah84ZUKSWg7pO
         41wMS5CQ+QLR4JnPeEQaqT53A8lHZp8Mjoc0FWOhSMZrmAvJaoLd8N8DGvTV1ICCF8B5
         okDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=s06gUHZ2A94OfxwxQfdWLIAC7tIAdiruInxMVUxnnEo=;
        b=XPOig98T8fuePl5XEZhAdGFVnzGPMGkLfH3eazrE9LRkqdUFO8NOr87AYrpNsvdykt
         QY2xJ3ez+kkCZxd1BzETWtaSgaeEoHbIV8dgRLkoNRUi5BBpR6/WUm5msabG2I2AiFD3
         xQRFj8jFTPnLDu1mAlNmAxk2nlnLmwFJOHz16uieE8pzf+YRGG+FouuU0nOtMVw7E2uQ
         y0vVV/FtluaSUlQmH5vYNvNwQCm3ym9VaharyJy7ZK30MhNBj0UNHbAD7mFCPz3kVFnM
         5pSPrIiAVfKJ09R530c7IrHE+z3Bi42JO0JWQ2cB0WVIniImR3nX+FXBNcRssgGLQl/t
         fuyg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=MUqSj9NO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p13si2350195edm.325.2020.11.20.10.33.10;
        Fri, 20 Nov 2020 10:33:34 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=MUqSj9NO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730386AbgKTS2b (ORCPT <rfc822;thunderbird.krnldev@gmail.com>
        + 99 others); Fri, 20 Nov 2020 13:28:31 -0500
Received: from mail.kernel.org ([198.145.29.99]:48876 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729771AbgKTS22 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Nov 2020 13:28:28 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id DE97A24137;
        Fri, 20 Nov 2020 18:28:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605896908;
        bh=WqCP34BthLI/V/Ugps1321WWg/uGOwp1Bkswcw5xH0w=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=MUqSj9NOYZZn11h/pN7O2p8V/X30PrdaxH50CVuf4Sx707ujgZ3eddduMZ1DGNc1J
         mXCKOzblr4ZVOJKifszj/vaZYKp3T6D1jlyBkcZOWWMW7yZYgLuL+eJgFU4BL4Bspr
         1xcLf871ltFEmnZxhDbTeJUGMGIyeLXluPNBBoJw=
Date:   Fri, 20 Nov 2020 10:28:27 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Martin Schiller <ms@dev.tdt.de>
Cc:     davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5] net/tun: Call netdev notifiers
Message-ID: <20201120102827.6b432dc5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201118063919.29485-1-ms@dev.tdt.de>
References: <20201118063919.29485-1-ms@dev.tdt.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote:
> Call netdev notifiers before and after changing the device type.
> 
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>

This is a fix, right? Can you give an example of something that goes
wrong without this patch?