Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1597145pxb; Fri, 20 Nov 2020 13:41:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwTBVyDXIa5CF7qCCOOiNEqyzbVoEAGDNLWayyensayrpDMk8dvyP+bMSJg3KQLSy8DXPAp X-Received: by 2002:a17:906:ceca:: with SMTP id si10mr3153666ejb.409.1605908512869; Fri, 20 Nov 2020 13:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605908512; cv=none; d=google.com; s=arc-20160816; b=Cd8lVldHyjkWCkRWAH+z1IRtpegQwna16K3pvhAwAggZOo7ENZB51DpaBPxXjSZYV6 jel9BXA00ZJKSFVBJdQ3zYx90aZFK9X2dEEsF0yv4apYPrKjt124JmgxAiIbzmXrlVUF QTu6pXwxdy3agjxZXtYYfo8lfsRBRNQN4bIW/gVMYlBFB6vuyDk9fpe5bcsAIQuguF4T 3fCP9zIsqJtlmTZtbqZZM+r1i1yIfoT+p7z0aSbEdahsDlepQKL285ncsHxcoZoK7DxE TKtYbJvlHGHc+qEEu8AM+Pe5auMfwgAYnwA4/RCsDrqkfUkVPitNc3hghAtDAdCPn1au eyDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature; bh=vdgWyMqTZ/KgANno+C5rCsxsLffEg7/4wEFhdg4BzwI=; b=pefYvfEDOFfH3TceVk1sFE0eGbC+otiJ4T/x71KLyxmJIUANLLTdgCfp7XOSWBOEWH hWtY/dwxF2jnDFrj80Y/NPRFMuGmuXQL+vc8Fe7IKU66uZwgfA9/DY3Tblo2cy/+rg4U RgLGP89sUPA/vPztfI5jAMJEmPnz0VXKpkM9jw/+ZJ0tW0talMOFOv07CHg4qsRnoVYb A+g/XPHcbSjQO2FYhY0MawKhSSB8LrqU9vCetFP4AAc0zgOy+rtr3sfGgl9Di3n/JVir 061LA9mM0fApFhp/sm34T3ZDNIqA9HJzwNRULXYkGyv8cMMYyrVhqCj56eMP64Amnzxu qtUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=hjCAAPiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si2338868ejc.65.2020.11.20.13.41.30; Fri, 20 Nov 2020 13:41:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=hjCAAPiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728194AbgKTVin (ORCPT + 99 others); Fri, 20 Nov 2020 16:38:43 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:60948 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727905AbgKTVim (ORCPT ); Fri, 20 Nov 2020 16:38:42 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AKLc9ED004163; Fri, 20 Nov 2020 21:38:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=vdgWyMqTZ/KgANno+C5rCsxsLffEg7/4wEFhdg4BzwI=; b=hjCAAPiQuGKgg9PQlmF2CEhfXgsK4V3IL0TBllq3pwdLW2cAsCBNqTQ4ThGfPvnQoh9+ V7EbbfgvR6mElEDy6mt+/BayXJ+D9umRbQoMUux/U76sqn2bBS0eFkGWVhKyhmvo+iOW pOZGAsOecys9/DjyqOootIsFGCbj54uTsMShNy2TgH7R72HHP4isQNzlEyT35/1CmhDI JCsQZTzIA37BdmeXrTiRI13i2DeCcMcrOP56wP6TIXdMpjjWdE4ef5e6oK3KN5BTnDFc Ak9rAB4fR9ngZI1whbbshi5ybA/yEtPOObnfChfOccclqBnRcR5YseEhI/aYwHBhJ2g3 3Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 34t76mcr2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Nov 2020 21:38:31 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AKLVUlF003267; Fri, 20 Nov 2020 21:36:31 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 34umd3yqg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Nov 2020 21:36:31 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AKLaREe006534; Fri, 20 Nov 2020 21:36:28 GMT Received: from [10.74.102.87] (/10.74.102.87) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 20 Nov 2020 13:36:27 -0800 Subject: Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross , Stefano Stabellini , Jens Axboe Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <33057688012c34dd60315ad765ff63f070e98c0c.1605896059.git.gustavoars@kernel.org> From: boris.ostrovsky@oracle.com Organization: Oracle Corporation Message-ID: Date: Fri, 20 Nov 2020 16:36:26 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <33057688012c34dd60315ad765ff63f070e98c0c.1605896059.git.gustavoars@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9811 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9811 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011200143 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/20 1:32 PM, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/block/xen-blkfront.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index 48629d3433b4..34b028be78ab 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -2462,6 +2462,7 @@ static void blkback_changed(struct xenbus_device *dev, > break; > if (talk_to_blkback(dev, info)) > break; > + break; > case XenbusStateInitialising: > case XenbusStateInitialised: > case XenbusStateReconfiguring: Reviewed-by Boris Ostrovsky (for patch 138 as well) Although I thought using 'fallthrough' attribute was the more common approach. -boris