Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1644238pxb; Fri, 20 Nov 2020 15:13:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPTpNP9XsJs3XazSMWoo37yJ8hvYdNZUAHwtSwCXPFd/Xg7bn3+REbgqXubK0j/cKv2b+f X-Received: by 2002:aa7:d298:: with SMTP id w24mr13120865edq.82.1605914033905; Fri, 20 Nov 2020 15:13:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605914033; cv=none; d=google.com; s=arc-20160816; b=sG6wB1lJkJW53PbCzIJAx28MAAJfjsfCDz8taRVgd4quSgFf0hy9RnkcZ2VlA7mdQJ mj6m+FWgMi2dAI4q1lVRrCitjgnLA0ItuS6QQXcyjlVaTmOoYDr6SBQlTU+h8U3bGQsZ DxOeYerbDxbJB0DK3vNeOdqIh7KvPYXHiwTaqjqZMAbDmpJT7x9z7aD90fhA17TU38gT dUKoi9+7iThxx0oxU/T3KxlgWwwEmancvdtP8dzotF/BGu8LlzfwLJVkObWHTfFZV8Ng gJ/vkamOSipG38aZnhrVodVTTQjfBM2kv7vd3ZNd9m+Vrh9fRO3doGJeXjJhtgCdFwiA +GCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=UWPMH4F8zpYKMQ+iVwWJvlmgxu/1LnPnr3HnFQg/Y88=; b=WMI0VlG5ah6Jwh95WhPp4b16ZF8673+btDFuZhydGLZowl5gReJBgNYDwOEP/pcLhM xcyfdHfZgmbnVD6CRVV2EOzLiw1s3y09EE2XqRkwuplObnfJfvHfsztkbPJxk3OItoTh EyJ4PysPaH3kwPSekzrdg06sVJ6pmiXrZMqT9nIa/gN+kSBplTcFj2GBX/PjIkBLa/xx W8hNfaDYOErkl3E+u0G5+8R6/rISc1f22Y6CMQM1/go4J/cr4al6BHzzqxu5UEz++HpI IaDjXimkbvDL1ZOgUSQUQ+YpXZI6TBRdLUThnUX/xJUa4lIhTnMpXg/ej/vqYGzZJefk K0rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OiOHYUgL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p18si2538795ejd.689.2020.11.20.15.13.31; Fri, 20 Nov 2020 15:13:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OiOHYUgL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728884AbgKTXLT (ORCPT + 99 others); Fri, 20 Nov 2020 18:11:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728559AbgKTXLT (ORCPT ); Fri, 20 Nov 2020 18:11:19 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F89C0613CF; Fri, 20 Nov 2020 15:11:19 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id 131so9320214pfb.9; Fri, 20 Nov 2020 15:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UWPMH4F8zpYKMQ+iVwWJvlmgxu/1LnPnr3HnFQg/Y88=; b=OiOHYUgLaPXz88CxKOhR4d3ZFqH0WOaQDpA+KqZxYvwRPo+uT1j6TXzvSd1Wk1VMVd huzg4SXZYqZnkcGlSFveMgn5IcRIktiabykZLdux4TCJtNsAtSk0F/fH/eeJ4oQxco1t Ussp3YptQZfqMjiLQ3hYdU0YPBKiZsGxnhyfE84XT1WO20knxUt48hhrCNu0MeoDUPrb 8h5I/RvyrczBjFazMLoZ2d+CQ4HmM+87kGUkTUL86ogd0heqRPwue4uSF2gG5sTeg2nY xxr5G2svkZHRS5rWea3Wzq5yQNVPUc/7/7UlyS43zkCWDGCsLpkQuc58N+ohaQGlHVmn +z6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UWPMH4F8zpYKMQ+iVwWJvlmgxu/1LnPnr3HnFQg/Y88=; b=SbdWDYIxtqi6zTv2mqp+D4cCv5Mo/OxImRIB3cG/apU6S9bNHe9T67XDkl8SEB4/Z3 vmTmbFWN3fjojJm9JmVt37Re1WygE+z5RF/eE4M1D6aXswiaoM0Uz3HXG2fvl88I2WUE 2viSGqUOnYppcQttzujHLimKYU4G/ZlVboSStbiGsh5CbcVIpUCOc9p+FUa+G/MnB9H5 s0fIPKi+CSbyZbEvORT0Mh57qgDDt4ZTA1ydSeptJHrvzbsaFDpBO6wvd2+kj+9GPwxU GfPDTC9FySL2bW4uTa1u5m3gF1dLYDO6pOnaSfwJfNsRi3LzKsecMagjYpNl2ORb18u2 NZgA== X-Gm-Message-State: AOAM531ITaw1TQP0L9VyQjggS8UwyAjLKb5pOZWCBIqUT3zvS+B+Jhgy 72DNQJRY/ctU7R/3ZEwv+bd42G0zNDfX4AOXsD8= X-Received: by 2002:a62:170a:0:b029:196:5765:4abc with SMTP id 10-20020a62170a0000b029019657654abcmr16122116pfx.4.1605913878966; Fri, 20 Nov 2020 15:11:18 -0800 (PST) MIME-Version: 1.0 References: <20201120054036.15199-1-ms@dev.tdt.de> <20201120054036.15199-3-ms@dev.tdt.de> In-Reply-To: <20201120054036.15199-3-ms@dev.tdt.de> From: Xie He Date: Fri, 20 Nov 2020 15:11:08 -0800 Message-ID: Subject: Re: [PATCH net-next v4 2/5] net/lapb: support netdev events To: Martin Schiller Cc: Andrew Hendry , "David S. Miller" , Jakub Kicinski , Linux X25 , Linux Kernel Network Developers , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Should we also handle the NETDEV_UP event here? In previous versions of this patch series you seemed to want to establish the L2 connection on device-up. But in this patch, you didn't handle NETDEV_UP. Maybe on device-up, we need to check if the carrier is up, and if it is, we do the same thing as we do on carrier-up.