Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1667093pxb;
        Fri, 20 Nov 2020 15:58:44 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyeCFW+6VPqhrn8BrhWhB4cnjOKUuQNhwX3TtR+l4RQd7o7DgD9lkiSCe0Jjt5TikBijxVV
X-Received: by 2002:a17:906:e53:: with SMTP id q19mr36150788eji.254.1605916723794;
        Fri, 20 Nov 2020 15:58:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605916723; cv=none;
        d=google.com; s=arc-20160816;
        b=ylatPV+QPoDKtKcw7HsCtG5m3psQEGbr72UeYmF85oNndnJdhm4L7FnuCFsQ8n1Qmh
         L60/Yslaund6t2ToF6hMbtBceFb7XuIE1wq3W+YAIOh000N7EIc574hWmbFRe5tFxA2d
         WWYLj7VovwUKzu7XkphvWetZ1u3w/SD1+r1vvKDFwFCSXxpzlK6heoRh2GFFidL1D3BZ
         vCaLOO/eu3LXlIkwP7KJjiex6DNwXl9Vhz9nDsSGTzv8TvEKgQz/mTQg/t9FqhtiCS3M
         fvPgEJFsY4AM6jZ1yHHWxPK5q7o+qyganvuhPMXb/tXgg4BXnjq+UBveBA/GOxZ3rPTh
         zYaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=vEExIa/isnY/BlrXUvbUKMr1m6ZMVNC9fdsRi02TS+M=;
        b=mgmJVjR1tPfI8wqGKx/h9eJk5FltuJ+Tflk+19gFE8vGXqNU/QkWRHv46GBfq1LOVB
         /0eZ2mSIYwWi+KB0u/TT/zjT+X+sF0IbmmDZpew4WWbOvdElDgIISVBGYd+7uQKl5h9p
         rygOxuX6VVy4vbLwJbeMfHChOwTulUEAre5c/GfCJV01JmcI4s060MZM5DT40WWS5rDz
         GLPU4EseWS70OQRPJaoL9yGr3ryV0Jzq8XM2A+9qEX+v+QUWKY3U1D6BgJTi4nPSQdvK
         H5n8m2TDJ/aBx/Gv0i82jA00M9+62HrmlV18AjWS1wGyWSo6rtIMliaJ4PB88FitevPr
         Ifxw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=uB5x7td2;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y14si2302073edj.388.2020.11.20.15.58.20;
        Fri, 20 Nov 2020 15:58:43 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=uB5x7td2;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728341AbgKTX4j (ORCPT <rfc822;thunderbird.krnldev@gmail.com>
        + 99 others); Fri, 20 Nov 2020 18:56:39 -0500
Received: from mail.kernel.org ([198.145.29.99]:53992 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727364AbgKTX4i (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Nov 2020 18:56:38 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 05A9C223B0;
        Fri, 20 Nov 2020 23:56:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605916598;
        bh=Ar7jfRIwyvlS8JFQ4Z8QxItcibMLIRuRFg/GfBbojhQ=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=uB5x7td2syoJ37gB0OdPmU74R0RzWIKpoY5w1fb00TRRocUuLSz8GGwZ6/xEzNoFg
         vLCWrl5rtpol4SGQF3l+JRyQihLGhWBFnynIIc9LseiRX9Uk3YJsjDZn7m7vAgAPVR
         E4nN7sru95qQzBu9M+wupxIVfSGynZi4HNvF7DQo=
Date:   Fri, 20 Nov 2020 15:56:37 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ion Badulescu <ionut@badula.org>
Cc:     xiakaixu1987@gmail.com, leon@kernel.org, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kaixu Xia <kaixuxia@tencent.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode
Message-ID: <20201120155637.78f47bc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <fe835089-3499-0d70-304e-cc3d2e58a8d8@badula.org>
References: <1605858600-7096-1-git-send-email-kaixuxia@tencent.com>
        <20201120151714.0cc2f00b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <fe835089-3499-0d70-304e-cc3d2e58a8d8@badula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote:
> Frankly, no, I don't know of any users, and that unfortunately includes 
> myself. I still have two cards in my stash, but they're 64-bit PCI-X, so 
> plugging them in would likely require taking a dremel to a 32-bit PCI 
> slot to make it open-ended. (They do work in a 32-bit slot.)
> 
> Anyway, that filter code could use some fixing in other regards. So 
> either we fix it properly (which I can submit a patch for), or clean it 
> out for good.

Entirely up to you.