Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1678758pxb; Fri, 20 Nov 2020 16:20:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJXoG1JiQgvHHiyt2tldBGGC3tnIjIhMDMmVAhFqkERz45o2+5VzW6vC7enITs80QxVty+ X-Received: by 2002:a50:9e05:: with SMTP id z5mr36221630ede.231.1605918052935; Fri, 20 Nov 2020 16:20:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605918052; cv=none; d=google.com; s=arc-20160816; b=fiqMb01zZ+3nGDCmE7pQkICVoPsKiG9UGr7g1W+ymT3HNGycWcTjSdekQMFKzLVktP KfskQ7a9R1s0DnQi4JsF79gHgL3St81ZaEb58C0Gv6g2JY6iblrnSfJ03N66w/8lb+vj 6OXRWO2Zizj3QPzw3ONRxWn//YDP6LidM0f0IB26xahfekxo+c/v3DIuq/5SL2Xynrw5 +bCbh2nXP2GAO6Xh+nHIEiiZ8qXG7F7AYcd8u26g0n+3wHtvj5BGIH7QPoaEmmRyV/M5 VHSg1blQKrq8uzQ7U01QRLLxynmkHQbWTxlSkgNvcn01g2bYvCmpMUtkzO84s+u2gpoY 6llw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=y0pJ80u9Eh3VfP4FijeIg1t6JgwYwt6NQdfyVaOMVqE=; b=zptU19cxrECdAFNJ37gmmOouIs0Kv8sQ37AyihexO1PNzNYuAuJnzXZO5IgBLBanhE Tngcx10gtIGYtle/KWeBRNJfpcvjeQ71mSBgIl+knEwJTA3y2NRMcTTFt8uJj1NpQE1B AW3XByElLqwopQfzv9NH1AXNbeSQ1mpwR6muziMye9ahCQb3n9ACatLpCt0yKrVMJDsU eXIAM0s++bErwTlk1O78jHtpwrxSoInwMcorR3V4/bgtwPUrMWaXKIo7QoehIGNYXSre QLupmSFnjFnd4ooMAgPMj3C934xOUOSlhou5sJ1ymmdAr3IgBIDs90v6eYgkrF+Cf5ML wRAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mNRCMhZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si2666091edu.277.2020.11.20.16.20.29; Fri, 20 Nov 2020 16:20:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mNRCMhZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbgKUAS6 (ORCPT + 99 others); Fri, 20 Nov 2020 19:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727367AbgKUAS5 (ORCPT ); Fri, 20 Nov 2020 19:18:57 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B929EC061A47 for ; Fri, 20 Nov 2020 16:18:57 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id 131so9445589pfb.9 for ; Fri, 20 Nov 2020 16:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y0pJ80u9Eh3VfP4FijeIg1t6JgwYwt6NQdfyVaOMVqE=; b=mNRCMhZyQ/r9RL3BPK9hfjr6LmrPY+hxr51iSpROvULOHDBUzO13Rwd6Wet+Jt8YkQ SZ0TaMbRptcV50sXt1vb+wVP9NafY9vzBYVZUNArYXHLE7+A4yLDXUMFSa+074SUw703 MVLGoKCigzZWPNfYE4syBih8Ql2Xm14hqF8eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y0pJ80u9Eh3VfP4FijeIg1t6JgwYwt6NQdfyVaOMVqE=; b=XwU7Uh1TZzZKPm42cyIZnSFb7sUV5rXVms87cKegR1s7fl7lCAGNM6e6xe5lrTX8zm BZnzkLFnROlhxz0pFYMlsgT0MzHH7vF5n68ywusBTCYAsYBZfodNXoIwrBiKP9kjgDEb EMqlsTUEOuVMGdr4e45f48CkiuRFlTFHHbRQMWpxGA5VFsDuLKihS7Lph/BgiVuKtjLB 5t+K8EogrHbKQZlb0qnt0XaHEXOOdUNvz0EEk7zUgnjrtSCOeGN4DW/UmXbJL9mx3ZhK /uEHt5lDAZJtsUNsr0QKcI6rquaHU2C4r/P806u7kOsumGggO9V6/rGNLDJJAGRSCpDt 4F7A== X-Gm-Message-State: AOAM532eDReA//ZOP59gLfLUtWXpLWu0NVVu87c0q9N5RfAWTEghcEkm 914/xKA+5pudabMBZgFbfFrg8w== X-Received: by 2002:aa7:86d8:0:b029:18b:585b:3b16 with SMTP id h24-20020aa786d80000b029018b585b3b16mr15538520pfo.72.1605917937114; Fri, 20 Nov 2020 16:18:57 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c11sm5470547pjn.26.2020.11.20.16.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 16:18:56 -0800 (PST) Date: Fri, 20 Nov 2020 16:18:55 -0800 From: Kees Cook To: Gabriel Krisman Bertazi Cc: luto@kernel.org, Rich Felker , tglx@linutronix.de, christian.brauner@ubuntu.com, peterz@infradead.org, willy@infradead.org, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org, gofmanp@gmail.com, kernel@collabora.com Subject: Re: [PATCH v7 3/7] kernel: Implement selective syscall userspace redirection Message-ID: <202011201618.62E507D@keescook> References: <20201118032840.3429268-1-krisman@collabora.com> <20201118032840.3429268-4-krisman@collabora.com> <87a6vdmedy.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6vdmedy.fsf@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2020 at 12:43:05PM -0500, Gabriel Krisman Bertazi wrote: > The existing interface could be extended with a flags field as part of > the opcode passed in argument 2, which is currently reserved, and then > return a FD, just like seccomp(2) does. So it is not like the current > patches couldn't be extended in the future if needed, unless I'm > mistaken. Yes, I'd prefer this series go in as-is, and if there is a need for extending the API, arg2 can have more values added. -- Kees Cook