Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fs/stat: set attributes_mask for STATX_ATTR_DAX
To:     XiaoLi Feng <xifeng@redhat.com>, linux-kernel@vger.kernel.org,
        ira.weiny@intel.com, darrick.wong@oracle.com
Cc:     Xiaoli Feng <fengxiaoli0714@gmail.com>
References: <20201121003331.21342-1-xifeng@redhat.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <21890103-fce2-bb50-7fc2-6c6d509b982f@infradead.org>
Date:   Fri, 20 Nov 2020 16:58:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201121003331.21342-1-xifeng@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

I don't know this code, but:

On 11/20/20 4:33 PM, XiaoLi Feng wrote:
> From: Xiaoli Feng <fengxiaoli0714@gmail.com>
> 
> keep attributes and attributes_mask are consistent for
> STATX_ATTR_DAX.
> ---
>  fs/stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/stat.c b/fs/stat.c
> index dacecdda2e79..914a61d256b0 100644
> --- a/fs/stat.c
> +++ b/fs/stat.c
> @@ -82,7 +82,7 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
>  
>  	if (IS_DAX(inode))
>  		stat->attributes |= STATX_ATTR_DAX;
> -
> +	stat->attributes_mask |= STATX_ATTR_DAX;

Why shouldn't that be:

	if (IS_DAX(inode))
		stat->attributes_mask |= STATX_ATTR_DAX;

or combine them, like this:

	if (IS_DAX(inode)) {
		stat->attributes |= STATX_ATTR_DAX;
		stat->attributes_mask |= STATX_ATTR_DAX;
	}


and no need to delete that blank line.

>  	if (inode->i_op->getattr)
>  		return inode->i_op->getattr(path, stat, request_mask,
>  					    query_flags);
> 

thanks.
-- 
~Randy