Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4] fs/aio.c: Cosmetic
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Alejandro Colomar <alx.manpages@gmail.com>,
        Benjamin LaHaise <bcrl@kvack.org>,
        Andreas Dilger <adilger@dilger.ca>,
        Joe Perches <joe@perches.com>, linux-aio@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201103095015.3911-1-colomar.6.4.3@gmail.com>
 <20201120220647.8026-1-colomar.6.4.3@gmail.com>
 <cdcef7ab-3f06-1d61-35d5-dc9dd2561b8c@infradead.org>
From:   Alejandro Colomar <colomar.6.4.3@gmail.com>
Message-ID: <5764192e-60c4-dd98-8b3f-992f53c02a2f@gmail.com>
Date:   Sat, 21 Nov 2020 12:41:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <cdcef7ab-3f06-1d61-35d5-dc9dd2561b8c@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Randy,

Thanks for the review.
Next time I'll do it in two parts, as you wished.

Thanks,

Alex

On 11/21/20 2:22 AM, Randy Dunlap wrote:
> On 11/20/20 2:06 PM, Alejandro Colomar wrote:
>> Changes:
>> - Consistently use 'unsigned int', instead of 'unsigned'.
>> - Add a blank line after variable declarations.
>> - Move variable declarations to the top of functions.
>> - Invert logic of 'if's to reduce indentation and simplify function logic.
>> 	- Add goto tags when needed.
>> 	- Early return when appropriate.
>> - Add braces to 'else' if the corresponding 'if' used braces.
>> - Replace spaces by tabs
>> - Add spaces when appropriate (after comma, around operators, ...).
>> - Split multiple assignments.
>> - Align function arguments.
>> - Fix typos in comments.
>> - s/%Lx/%llx/  Standard C uses 'll'.
>> - Remove trailing whitespace in comments.
>>
>> This patch does not introduce any actual changes in behavior.
>>
>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>> ---
>>
>> Hi,
>>
>> I rebased the patch on top of the current master,
>> to update it after recent changes to aio.c.
>>
>> Thanks,
>>
>> Alex
>>
>>  fs/aio.c | 466 +++++++++++++++++++++++++++++--------------------------
>>  1 file changed, 243 insertions(+), 223 deletions(-)
> 
> Hi,
> I reviewed this patch.
> I think it looks OK, but I wish that there was a better way to review it.
> 
> I'm not asking you to redo the patch, but I think that it would have been easier
> to review 2 patches: one that contains trivial changes[1] and one that requires
> thinking to review it -- where the trivial changes are not getting in the way
> of looking at the non-trivial changes.
> 
> [1] the trivial set of changes, taken from your patch description:
> 
>> - Consistently use 'unsigned int', instead of 'unsigned'.
>> - Add a blank line after variable declarations.
>> - Move variable declarations to the top of functions.
>> - Add braces to 'else' if the corresponding 'if' used braces.
>> - Replace spaces by tabs
>> - Add spaces when appropriate (after comma, around operators, ...).
>> - Split multiple assignments.
>> - Align function arguments.
>> - Fix typos in comments.
>> - s/%Lx/%llx/  Standard C uses 'll'.
>> - Remove trailing whitespace in comments.
> 
> OK, that's everything except for this:
>> - Invert logic of 'if's to reduce indentation and simplify function logic.
>> 	- Add goto tags when needed.
>> 	- Early return when appropriate.
> 
> 
> thanks.
>