Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2069643pxb; Sat, 21 Nov 2020 07:49:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWeLAMgBKvSjVyddb61iKhpUWUHNmCA4Wbi/ehHFCIF1vfhUypXG+H7954tszbpJQmNO8W X-Received: by 2002:a17:906:7aca:: with SMTP id k10mr36120541ejo.215.1605973740266; Sat, 21 Nov 2020 07:49:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605973740; cv=none; d=google.com; s=arc-20160816; b=krctJDQUVydgLIZlpeI1crGMDehf/qANADkL+tTZ8OhAlVgfxnwlhX7T+lolJem4+h lOUhbypKhgCLzmpaRN9vjeoTiSq3hhk3q0xbvT+DfrNXYpvAJm2bI/NWreq7MGMWGKDn A9oSXSPvHHrLWyjhCbvdwqvNzZ2Sx/oDco+NqwDALIujcjLEObrnngR8Pjdpdww/kVYk 9/YM1pzUqZkx2B0QPJx5cFK1w2rilPGNGxPDn+OqhzrrCjIm/EN12chkAzUfYmZjOhsP BVoIQxzsawaHZDWHSJdKBm09pcBEGdmUWYoiKExp8JQpzeKN3+v6jNft0So8VaDY0ozp DdEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=93T2umDm49vM/MNu8XBHtG4smNCD+2/etg/kCSIeb8Q=; b=cUBm03G6iMTEfE3+Lw0X/bM74J+uO7NHRGIlIU6I8pK2v+Lw1zmt4FnhSHMcjeeyj+ Ba5f/jLFr5+9rcojWvv5iYw6eiB7FDOSEa8S/tzQBxE/0S2R3MkNUu6sneR+6IfV/asn hdgLq1/kEY+qb87PSfrJ009xdQfUjRU40I627hdr3G6yJSCmdbRMbOF7nrgJtO+xPiMy EVF0OUXqZ6M7Yqsi46S16goHH034II7sbnPyEZwo6Lf5MVUgNICHzm+ROZQmKLfidfoi gEXdTL1/Yi9fpvH1QByTQADx02uwAQVoLh1EzmIiGVfsQCKxmIzGTzPB14uzU7Yt6QuL QvGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BPBMz81l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l22si3728929edt.34.2020.11.21.07.48.36; Sat, 21 Nov 2020 07:49:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BPBMz81l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgKUPke (ORCPT + 99 others); Sat, 21 Nov 2020 10:40:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:58504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727854AbgKUPke (ORCPT ); Sat, 21 Nov 2020 10:40:34 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8D4E221FE; Sat, 21 Nov 2020 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605973233; bh=McaOV8/zg42IEF5gX/n6qLoPnRy6MYlv2RrjL5vHdY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BPBMz81lFJ2F++dCLKNHA/Izk7ylw4YLhmqjC47V30GVAEG9U06gEpU+enwG1xv5h /lhCblg9rmpt+TsnGTRBXbAxqxab3C7C81jYn2Y7AqjjHwMyKMC4YUx1jvYbHGMR4v Zf0WQWkALgYqIXAEK1UBx5TmkS/mfqB2n25vibM8= Date: Sat, 21 Nov 2020 15:40:29 +0000 From: Jonathan Cameron To: Alexandru Ardelean Cc: , Subject: Re: [PATCH] iio: accel: adis16209: remove unneeded spi_set_drvdata() Message-ID: <20201121154029.3950c659@archlinux> In-Reply-To: <20201119141806.84827-1-alexandru.ardelean@analog.com> References: <20201119141806.84827-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Nov 2020 16:18:06 +0200 Alexandru Ardelean wrote: > There is no matching spi_get_drvdata() in the driver. This looks like a > left-over from before the driver was converted to device-managed functions. > > Signed-off-by: Alexandru Ardelean Applied > --- > drivers/iio/accel/adis16209.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c > index 4a841aec6268..6c2d4a967de7 100644 > --- a/drivers/iio/accel/adis16209.c > +++ b/drivers/iio/accel/adis16209.c > @@ -279,7 +279,6 @@ static int adis16209_probe(struct spi_device *spi) > return -ENOMEM; > > st = iio_priv(indio_dev); > - spi_set_drvdata(spi, indio_dev); > > indio_dev->name = spi->dev.driver->name; > indio_dev->info = &adis16209_info;