Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp78045pxu; Sun, 22 Nov 2020 00:03:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJykguD4FTa9Trgvevl6IE2Ajw5h4E2aHo+/t8z4pEZ0pO6i9OAQiOVpmgllNk0FfueV7z8n X-Received: by 2002:a50:d5dd:: with SMTP id g29mr43528153edj.379.1606032231707; Sun, 22 Nov 2020 00:03:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606032231; cv=none; d=google.com; s=arc-20160816; b=pRantbodMQ7flBb0RHBLHjavjrz04jie5mTkXOjX5CSlZ8jnGD1FyiXTHfTonVgTfa H8Ea5hbi5ngqcjbqomd4lhKzxxzSWypRe5Vd9ZA76O2DOw2xns+uCmMrn+0CnV7VrHPy wcrN0oS7pktpuYaa6CRu+i3cEn8JFM7bDg4eSZBO29PiwU4VOGX0KqzePcolxL5x1q7S UdhZQDwVNrtoE5orsiKMVRYT6k3z2TCt95OYYBM9Mpr3+MMzwHYq/PBWs1nFYTjmpJAO eA9VMCVD4anut1Aq6cMggmrMiZ9w4qrf4gRHSmqNrkY5O5meaeCRIYRh4GrvGVSMEiid 9jcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=to5AyTdp77VlPDh1AshkR7YNXjVXtHl78yg1+vRHnJw=; b=zyBF6EM2HIKSZq3qq/ImEC6sHKcKGdT+p0vvo7zuqLq8+ATpMmJtsMfzfyQ6zSHk0G i4Zbt+knYWDi/lFMG8iEBBiM8AhxipU7uJeaHXcyWj/imcFuiq7StxHvYPPtYuNKrh8q JaxhLzDC18AWeo+PLsm1aJpC7Jx3mjxExunENcqorlFDDbiGoh1SWJ7wsGwSyBvG8ilY rERCFJHeOryFAZtqNchx9Ugr3hHKy/tMP/4iT9AmVUHzHL1uY6jXh0fk7Kbj1ZYvGcYN ftJAC/7+YiocMcXm40r8OgGTwk7F7Mng9xKPfSZB66D6XiHhBEVYZO2zAHO5DQjHRTDt WKtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sLpnABnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si1211734eja.341.2020.11.22.00.03.28; Sun, 22 Nov 2020 00:03:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sLpnABnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbgKVIBn (ORCPT + 99 others); Sun, 22 Nov 2020 03:01:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:40392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbgKVIBn (ORCPT ); Sun, 22 Nov 2020 03:01:43 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DB852078E; Sun, 22 Nov 2020 08:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606032100; bh=Fv9ziXyMoxfkJt/o/JsSYt1VLSXkbD0M5x/rvgfTmJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sLpnABnT5X8mv/nHoOfcfMgAxYUgUa4zrkKr6BqTR7I8kylTelURPX/Vj2L5zudUW r9MyXNFnjmWGZlqc8oaICYOFgxInIw0CQrZAyGvJGgqQdSe0rjIwckI4lfZDmnT4uV WAx7cy9Pgsq5xp+hzmqReGiJyYhaULbye4lRv6sM= Date: Sun, 22 Nov 2020 09:01:36 +0100 From: Greg Kroah-Hartman To: Daniel Axtens , Guenter Roeck Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org Subject: Re: [PATCH 4.9 00/16] 4.9.245-rc1 review Message-ID: References: <20201120104539.706905067@linuxfoundation.org> <20201121183446.GC111877@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201121183446.GC111877@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 21, 2020 at 10:34:46AM -0800, Guenter Roeck wrote: > On Fri, Nov 20, 2020 at 12:03:05PM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.245 release. > > There are 16 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sun, 22 Nov 2020 10:45:32 +0000. > > Anything received after that time might be too late. > > > > Build results: > total: 168 pass: 166 fail: 2 > Failed builds: > powerpc:cell_defconfig > powerpc:maple_defconfig > Qemu test results: > total: 382 pass: 377 fail: 5 > Failed tests: > ppc64:mac99:ppc64_book3s_defconfig:smp:initrd > ppc64:mac99:ppc64_book3s_defconfig:smp:ide:rootfs > ppc64:mac99:ppc64_book3s_defconfig:smp:sdhci:mmc:rootfs > ppc64:mac99:ppc64_book3s_defconfig:smp:nvme:rootfs > ppc64:mac99:ppc64_book3s_defconfig:smp:scsi[DC395]:rootfs > > Build failures see below. Note that the failures are different than the > failures observed in the v4.4.y release candidate, meaning that some > additional errors may not be reported. > > Tested-by: Guenter Roeck > > Guenter > > --- > Building powerpc:cell_defconfig ... failed > -------------- > Error log: > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from arch/powerpc/lib/checksum_wrappers.c:24: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror] > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror] > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: all warnings being treated as errors > make[2]: *** [arch/powerpc/lib/checksum_wrappers.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[2]: *** wait: No child processes. Stop. > make[1]: *** [arch/powerpc/lib] Error 2 > make[1]: *** Waiting for unfinished jobs.... > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from arch/powerpc/platforms/cell/spufs/syscalls.c:8: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror] > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror] > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: all warnings being treated as errors > make[4]: *** [arch/powerpc/platforms/cell/spufs/syscalls.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from crypto/cipher.c:17: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from crypto/compress.c:15: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > cc1: some warnings being treated as errors > make[2]: *** [crypto/cipher.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/asm-generic/termios-base.h:7, > from arch/powerpc/include/asm/termios.h:20, > from include/uapi/linux/termios.h:5, > from include/linux/tty.h:6, > from kernel/signal.c:18: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from include/crypto/algapi.h:15, > from crypto/memneq.c:62: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > > Building powerpc:maple_defconfig ... failed > -------------- > Error log: > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from arch/powerpc/lib/checksum_wrappers.c:24: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror] > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror] > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: all warnings being treated as errors > make[2]: *** [arch/powerpc/lib/checksum_wrappers.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [arch/powerpc/lib] Error 2 > make[1]: *** Waiting for unfinished jobs.... > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from crypto/cipher.c:17: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > make[2]: *** [crypto/cipher.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from crypto/compress.c:15: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > make[2]: *** [crypto/compress.o] Error 1 > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/uaccess.h:8, > from include/linux/crypto.h:26, > from include/crypto/algapi.h:15, > from crypto/memneq.c:62: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > make[2]: *** [crypto/memneq.o] Error 1 > make[1]: *** [crypto] Error 2 > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/asm-generic/termios-base.h:7, > from arch/powerpc/include/asm/termios.h:20, > from include/uapi/linux/termios.h:5, > from include/linux/tty.h:6, > from kernel/signal.c:18: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/asm-generic/termios-base.h:7, > from arch/powerpc/include/asm/termios.h:20, > from include/uapi/linux/termios.h:5, > from include/linux/tty.h:6, > from arch/powerpc/kernel/setup_64.c:27: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror] > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror] > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > make[2]: *** [kernel/signal.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > cc1: all warnings being treated as errors > make[2]: *** [arch/powerpc/kernel/setup_64.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [arch/powerpc/kernel] Error 2 > In file included from arch/powerpc/include/asm/kup.h:10:0, > from arch/powerpc/include/asm/uaccess.h:12, > from include/linux/poll.h:11, > from fs/bad_inode.c:16: > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class > DECLARE_STATIC_KEY_FALSE(uaccess_flush_key); > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int] > arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration > arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’: > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’? > if (static_branch_unlikely(&uaccess_flush_key)) > ^~~~~~~~~~~~~~~~~ > do_uaccess_flush > arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors Daniel, your commit broke this on 4.9, and on 4.14.y. If you could provide fix-up patches for these trees as well, that would be great. thanks, greg k-h