Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp212058pxu; Sun, 22 Nov 2020 05:36:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBRCam/v78EX0w+Aa39IgKwCh1X86kkQ3eUX6mapZOv8yjAUwAKRlR2+gqOsYm3Aj5kUqT X-Received: by 2002:a50:fc85:: with SMTP id f5mr13780409edq.225.1606052161628; Sun, 22 Nov 2020 05:36:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606052161; cv=none; d=google.com; s=arc-20160816; b=LXA6Oq1Q8eZIURE+Hs8geyMu79an4V4eqtrx/SUkkAWuYo7EFxeBFwOFNBuGuuj3hW Jvb3ufLKhCUp+fVk/Z9lrmXJCzJNELyMGOP5ggNm/hNo0S4+/zrza2QtuUH3wWUEmN/C VT8C4Hppe6gd7/wGeY3zzILm7jaRSllRQR6TuK1rBtdzpsB/w/lA2g+BplMKsWKn6oTx GdVvgaFRPhKuFoMk45jzSuRuq/BFnl6dPdBua8nybDaLcEEjhLCqByWjS8y4xKZ70RDv 8jjSeC1+vEBxPECj1pWkvYfLI10t2hxd7EG+EpmKZupNxCMooaSXnlahDFD0/KuHwlWA WfiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=lnPf0qqP5JlhbpeDaQweU3dHG38zjWq/RJM2h9qX9nk=; b=o36c6U82ExapR1QAKNBf3tqZBKIjr5s0YRUC+uRlsVAj1YBryjUjyanfaJC/AdOsNt OEymdNzwNeOEFiPb0nltnDGFqAIEobFQE8ohFq59UCcXERIRVxb/W0IwbZrFb0IAxAfd iAkPnlB7hfiEP/iwiDHeLOiw7HXFWgt+0WGu3aBVdNaEvKmKFXkCIbsYU+rHaiBuWHmA 7M4I4Hz8SuzOyEcEX0TodsA6Wt0i1Pt+WkeNqpUedxmLSev7yYcW2JvGIdtbpFdfwuCU tzu9ZZ6GzaZCXQHKYTclDam3kNLGhuAYlbluwDv6NHErrrK4cSX9eQaHTj75vsdFfu8b 7d1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GWERhRBH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz19si5773686ejb.699.2020.11.22.05.35.38; Sun, 22 Nov 2020 05:36:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GWERhRBH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727845AbgKVNdP (ORCPT + 99 others); Sun, 22 Nov 2020 08:33:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53139 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgKVNdO (ORCPT ); Sun, 22 Nov 2020 08:33:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606051993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lnPf0qqP5JlhbpeDaQweU3dHG38zjWq/RJM2h9qX9nk=; b=GWERhRBH/+dG1OatJBcPmNkGouYC/T7pfwjb2l1LWr6CWIas3uB1uzuD1+h8DRYIw6ob5W E7Vn7hwOWhZ9GsffLhDmIHFNjPxkVdDioZBu+tniYOY3mpdnmHHV7cyP1PWUdiuoKMt4K5 F9RNpa80F1faApglPwcWeD5BOzs5ngE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-Z1FtuahSPYu6b0Cj1_fiog-1; Sun, 22 Nov 2020 08:33:09 -0500 X-MC-Unique: Z1FtuahSPYu6b0Cj1_fiog-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63AB0809DC3; Sun, 22 Nov 2020 13:33:07 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-246.rdu2.redhat.com [10.10.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B97710016F7; Sun, 22 Nov 2020 13:33:05 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <160596800145.154728.7192318545120181269.stgit@warthog.procyon.org.uk> <160596801020.154728.15935034745159191564.stgit@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Pavel Begunkov , Matthew Wilcox , Jens Axboe , Alexander Viro , linux-fsdevel , linux-block , Linux Kernel Mailing List Subject: Re: [PATCH 01/29] iov_iter: Switch to using a table of operations MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <254317.1606051984.1@warthog.procyon.org.uk> Date: Sun, 22 Nov 2020 13:33:04 +0000 Message-ID: <254318.1606051984@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > - I worry a bit about the indirect call overhead and spectre v2. I don't know enough about how spectre v2 works to say if this would be a problem for the ops-table approach, but wouldn't it also affect the chain of conditional branches that we currently use, since it's branch-prediction based? David