Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp538258pxu; Sun, 22 Nov 2020 18:37:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpFgRnU8lUlqoT6WeChj3amewNbGKAQLPS+ranqLTsKNarUhEXNwhVDuQRbgWAPMn1qlV5 X-Received: by 2002:a17:906:7d1:: with SMTP id m17mr42583923ejc.98.1606099020163; Sun, 22 Nov 2020 18:37:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606099020; cv=none; d=google.com; s=arc-20160816; b=cCRzm2huyumw54+M7lxvbul6mNGxDBWGg3rjg2tJ8V+X3Tu6v1rNxd/OgvNc9fI6eH HkDE+cu3W/mbV3Um+LxGg5ENVhPRnRjenCx5xyNVHnxMI4EW/j5WQDyHp8gD5wfm0Aut nr4Ii0oNWHXvvZ7Sg8iV6NzZahMd9OO43h9tdA27lhpeiJhFqggZpuk7mRDU7aceZdm+ hLCaq50pIUKyiKUuUxKkB0fFrXQwdu8XlzrlsezmyVrHAbastfYysGQ0zOKVMU/322pL 96pFa1AbInE+ifVqIpPSAJ4BUc5xLdHcRizbfQFAzkRkfgg4suwkwQWBTw/IPyi9RWNl PAYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7WQmreNz3Bg0iRWcEQDrInmhGuTWIyPdVtZxmzXya8Q=; b=Z4jeVMzDNMXkub+045q2vcRnYSf3WRH9qVOujOuR4QvBmF92v8iFxzHnyo4LuXyOL/ U1NdHQBMs1ZFTp3HCrjAW1A6/2gLvBrsC+KYxIgXssnsvK+adheaseZcUvwLJ5bqtztZ 4rMtFMa5Xp2u67BD42cEC9GxZ7hzJKemMUUY4/lG3Ybu4wprewrRXAzCVYRtSEULX8bR 6+1g0cbTXgj2SEFRwciOlDsdQKxNBZfvde8DYpgWqq8J+hNH4DoJapkD4HhwRaVlZVt3 d8n4QHi9rKCTLrefJP6gPEy0RNucsO3g/UxlNBBENmq6hihSW2sBDufUUk8odycTYVNl YLpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si5793687edy.599.2020.11.22.18.36.37; Sun, 22 Nov 2020 18:37:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726903AbgKWCYz (ORCPT + 99 others); Sun, 22 Nov 2020 21:24:55 -0500 Received: from foss.arm.com ([217.140.110.172]:51706 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgKWCYy (ORCPT ); Sun, 22 Nov 2020 21:24:54 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31B5930E; Sun, 22 Nov 2020 18:24:54 -0800 (PST) Received: from e113632-lin.cambridge.arm.com (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CAECF3F70D; Sun, 22 Nov 2020 18:24:52 -0800 (PST) From: Valentin Schneider To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , James Morse Subject: [PATCH v2 0/3] x86/intel_rdt: task_work vs task_struct rmid/closid write race Date: Mon, 23 Nov 2020 02:24:30 +0000 Message-Id: <20201123022433.17905-1-valentin.schneider@arm.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, This is a small cleanup + a fix for a race I stumbled upon while staring at resctrl stuff. Briefly tested on a Xeon Gold 5120 (m2.xlarge.x86 on Equinix) by bouncing a few tasks around control groups. Revisions ========= v1 -> v2 -------- Empty git diff between the two, but: o Collected Reviewed-by o Reworded changelogs (James) o Split READ_ONCE/WRITE_ONCE changes into separate patch (James) (@James: note that I had the audacity to slap your RB to that new patch, given that you already reviewed the diff. Hopefully you won't hate the CL too much!) Cheers, Valentin Valentin Schneider (3): x86/intel_rdt: Check monitor group vs control group membership earlier x86/intel_rdt: Plug task_work vs task_struct {rmid,closid} update race x86/intel_rdt: Apply READ_ONCE/WRITE_ONCE to task_struct .rmid & .closid arch/x86/include/asm/resctrl.h | 11 ++-- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 71 ++++++++++++++++---------- 2 files changed, 50 insertions(+), 32 deletions(-) -- 2.27.0