Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Daniel Axtens <dja@axtens.net>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org
Subject: Re: [PATCH 4.4 00/15] 4.4.245-rc1 review
In-Reply-To: <X7oahkxvsgCgDtrG@kroah.com>
References: <20201120104539.534424264@linuxfoundation.org> <20201121182903.GB111877@roeck-us.net> <X7oahkxvsgCgDtrG@kroah.com>
Date:   Mon, 23 Nov 2020 13:40:08 +1100
Message-ID: <87lfeshk3b.fsf@dja-thinkpad.axtens.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,
>> Build results:
>> 	total: 165 pass: 164 fail: 1
>> Failed builds:
>> 	powerpc:ppc64e_defconfig
>> Qemu test results:
>> 	total: 328 pass: 323 fail: 5
>> Failed tests:
>> 	ppc64:ppce500:corenet64_smp_defconfig:e5500:initrd
>> 	ppc64:ppce500:corenet64_smp_defconfig:e5500:nvme:rootfs
>> 	ppc64:ppce500:corenet64_smp_defconfig:e5500:sdhci:mmc:rootfs
>> 	ppc64:ppce500:corenet64_smp_defconfig:e5500:scsi[53C895A]:rootfs
>> 	ppc64:ppce500:corenet64_smp_defconfig:e5500:sata-sii3112:rootfs=09
>>=20
>> Failure in all cases is:
>>=20
>> In file included from arch/powerpc/kernel/ppc_ksyms.c:10:0:
>> arch/powerpc/include/asm/book3s/64/kup-radix.h:11:29: error: redefinitio=
n of =E2=80=98allow_user_access=E2=80=99
>>  static __always_inline void allow_user_access(void __user *to, const vo=
id __user *from,
>>                              ^~~~~~~~~~~~~~~~~
>> In file included from arch/powerpc/include/asm/uaccess.h:12:0,
>>                  from arch/powerpc/kernel/ppc_ksyms.c:8:
>> arch/powerpc/include/asm/kup.h:12:20: note: previous definition of =E2=
=80=98allow_user_access=E2=80=99 was here
>>  static inline void allow_user_access(void __user *to, const void __user=
 *from,
>>                     ^~~~~~~~~~~~~~~~~
>> In file included from arch/powerpc/kernel/ppc_ksyms.c:10:0:
>> arch/powerpc/include/asm/book3s/64/kup-radix.h:16:20: error: redefinitio=
n of =E2=80=98prevent_user_access=E2=80=99
>>  static inline void prevent_user_access(void __user *to, const void __us=
er *from,
>>                     ^~~~~~~~~~~~~~~~~~~
>> In file included from arch/powerpc/include/asm/uaccess.h:12:0,
>>                  from arch/powerpc/kernel/ppc_ksyms.c:8:
>> arch/powerpc/include/asm/kup.h:14:20: note: previous definition of =E2=
=80=98prevent_user_access=E2=80=99 was here
>>  static inline void prevent_user_access(void __user *to, const void __us=
er *from,
>>                     ^~~~~~~~~~~~~~~~~~~
>>=20
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks for testing these.
>
> Daniel, looks like your patches broke some configurations on powerpc as
> shown above.  Care to send a fix-up patch for these?

Will do. I tested ppc64e_defconfig but clearly that wasn't comprehensive
enough.

Kind regards,
Daniel