Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp620781pxu; Sun, 22 Nov 2020 22:30:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGjtJqW4UDimED0pM404wIDKvmnjB1dSvoqJAXfxe5rHDD49C8PAjDx0pJJ6QlvnuXielF X-Received: by 2002:a05:6402:154b:: with SMTP id p11mr46603422edx.217.1606113003119; Sun, 22 Nov 2020 22:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606113003; cv=none; d=google.com; s=arc-20160816; b=T4UN4hRBcc2WgdWLW/4E3kiQVU4wrVRrCm/dMhZfgs2jJBBGPFcfExVmyqFJIvwuAA 0vIx3kYCToEcaZPJfrdHnNcYPqRvTJiguzqr1oqYYJ5VFoqjgI1gGINcqZFhomr0KSRl OSkvAhZthqog7RkFdhNOe9r2gBnNSc8LHE0z57SXFKXRVv4mtVzrpd40Mum5Bf9y8D3v iw8/y4sqYLxvJUFwyC4DdmXM+VuLwhyP80MBQ3lJO4mVyI7yUmbuZ8gy9TVb01vpvavn JEZ3/E+tWdTYygQEtqb2uQbCESe2zvpQ1BVHsloWibVo1sJ5kjuqP+qNqK9G/WIBJs6S BIbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GKa7W0DjsQScUMdM+fh7P8EBsnhIK0qKVT7JJFmlduM=; b=JUxnZDEy1rwIVvw17sjl3h1qJ6mezzD446gBmbIcH+vHHSUdjrgsu7bJoNYbECY1o/ PCyAwy6hSRPGtDy6wvivGURIjZwISWb0FCnSgjlL1ACr+GABuIR89vGSOM7oRtm68fCw +eyMiLqEMPoBPuIxl1cm8IzlkINg3qahn/E/3HMAqoGJmhBKjDQe25EJFPs5YiGWGPlS gQzgTCJcGeL5925iiTvYc7UP1HmY9+NUjsQaUK9H0Ks22akVLC024S11p34IUadWW+Dm aAh/jscuKwMmW54RKWGjuS0mkkRH7MC3bC+A34/4UTiv23p+eyILRlp0hGNq04yrf7Wl kYBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rGEfXEwl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si6850897ejx.340.2020.11.22.22.29.39; Sun, 22 Nov 2020 22:30:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rGEfXEwl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbgKWGRi (ORCPT + 99 others); Mon, 23 Nov 2020 01:17:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgKWGRh (ORCPT ); Mon, 23 Nov 2020 01:17:37 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 994F6C0613CF for ; Sun, 22 Nov 2020 22:17:37 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id w16so912332pga.9 for ; Sun, 22 Nov 2020 22:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GKa7W0DjsQScUMdM+fh7P8EBsnhIK0qKVT7JJFmlduM=; b=rGEfXEwlr66TrbSIzeEJ5FDjg42pe+KTbVMCt3orA1E7AS+8bNxLN7hgHnv9wZ4zRW 7tpleeyHmO/Mk8recctOvWkoXB3ku7K//lc6CBgJCg0vWvIt2AJaVorT8KgtJz/s6UB0 cpghzzT0Whp/cpSh8xdsm+7U0PDuVKeQZYtYxg7x7LSYM7de4ahGiiU9M/u1Byu8drem otVZOkwRy7/W7UYjnbAxFwhn3Sd2uxThXBJZ4CVJgiBId/k4K2AClDUHlRFQFeBgjwHm rOckwkbQUfwnqqyNo7jur3VrxoBOcrEAz7n+xImPhIOplX5ie4p+LdjYQX3X+I048R3F +i1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GKa7W0DjsQScUMdM+fh7P8EBsnhIK0qKVT7JJFmlduM=; b=JYxDo/442ZFQLeg74J9kn1JhDrMh+oueLKvnMlEWAblsvIGgfVtQoLI6vTVApnP1SH t9R8IOPqbE+DC7UxrXeuQTfs671wF0x0BBM620fT6qZChrTmQTbTeQzmgkSWe6ZhCA+r SYFHIhbjRRJXiShGE97BJV45SgxNrfBB3ZED1PgEQX6phYOChcfKsB0+fD0Bj1DN6Rfc hdkxXNaOkrBbH39ukC3I6111xf93Qun7b0bSCcqbF4/myOacfxTm8TCofNa9uPEYH0B6 byYosht7xa5OpM58SZwz9VXtjY0eAzHq/iHANJ529WucydeCCv9fbtvdCvoxeRRxulFl kiwQ== X-Gm-Message-State: AOAM533agwD6YgwDjJckxQKjrCAvWTduHJvz737e/hPM0XpZl7cIOZlp 4TPZQzrEcFCaqt33QGarTPTV7w== X-Received: by 2002:a62:52d7:0:b029:18b:7093:fb88 with SMTP id g206-20020a6252d70000b029018b7093fb88mr24458173pfb.76.1606112257122; Sun, 22 Nov 2020 22:17:37 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id u197sm10953224pfc.127.2020.11.22.22.17.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Nov 2020 22:17:36 -0800 (PST) Date: Mon, 23 Nov 2020 11:47:34 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs Message-ID: <20201123061734.mpmkdxzullrh52o7@vireshk-i7> References: <20201123002723.28463-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123002723.28463-1-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-11-20, 03:27, Dmitry Osipenko wrote: > This series brings initial support for memory interconnect to Tegra20, > Tegra30 and Tegra124 SoCs. > > For the starter only display controllers and devfreq devices are getting > interconnect API support, others could be supported later on. The display > controllers have the biggest demand for interconnect API right now because > dynamic memory frequency scaling can't be done safely without taking into > account bandwidth requirement from the displays. In particular this series > fixes distorted display output on T30 Ouya and T124 TK1 devices. > > Changelog: > > v10 - In a longer run it will be much nicer if we could support EMC > hardware versioning on Tegra20 and it's not late to support it now. > Hence I added these new patches: > > dt-bindings: memory: tegra20: emc: Document opp-supported-hw property > memory: tegra20: Support hardware versioning and clean up OPP table initialization > > - Removed error message from tegra30-devfreq driver about missing OPP > properties in a device-tree because EMC driver already prints that > message and it uses OPP API error code instead of checking DT directly, > which is a more correct way of doing that. Looks good to me (from OPP APIs usage perspective). Thanks for continuing with this and fixing all the issues Dmitry. -- viresh